bsunanda:Run2-hcx89 Add DB objects for HCAL TP #15521

bsunanda · 2016-08-18T21:26:00Z

This adds 2 data base objects: HcalTPParameters which summarizes the TP implementation and HcalTPChannelParameters which contains parameters for each channel

cmsbuild · 2016-08-18T21:27:22Z

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CalibFormats/HcalObjects
CondCore/HcalPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

bsunanda · 2016-08-18T22:20:28Z

@cmsbuild Please test

cmsbuild · 2016-08-18T22:20:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14595/console

cmsbuild · 2016-08-18T23:20:59Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-08-18T23:21:12Z

-1

Tested at: ce1cb26

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15521/14595/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/DQMServices/StreamerIO/plugins/JsonWritingTimeoutPoolOutputModule.cc 
Copying tmp/slc6_amd64_gcc530/src/RecoMET/METProducers/test/testRecoMETMETProducers/testRecoMETMETProducers to productstore area:
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/DQMServices/StreamerIO/plugins/TriggerSelector.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/DQMServices/StreamerIO/plugins/DQMMonitoringService.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc: In member function 'void HcalDbProducer::TPChannelParametersCallback(const HcalTPChannelParametersRcd&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc:424:48: error: no matching function for call to 'HcalDbService::setData(std::unique_ptr::pointer)'
   mService->setData (mTPChannelParameters.get());
                                                ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.h:31:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc:33:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibFormats/HcalObjects/interface/HcalDbService.h:57:8: note: candidate: void HcalDbService::setData(const HcalPedestals*)

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

                 ^
1 warning generated.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CondTools/Hcal/src/HcalZDCLowGainFractionsHandler.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CondTools/Hcal/src/HcalLongRecoParamsHandler.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CondTools/Hcal/src/HcalChannelQualityHandler.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc:424:13: error: no matching member function for call to 'setData'
  mService->setData (mTPChannelParameters.get());
  ~~~~~~~~~~^~~~~~~
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-08-18-1400/src/CalibFormats/HcalObjects/interface/HcalDbService.h:57:8: note: candidate function not viable: no known conversion from 'pointer' (aka 'HcalTPChannelParameters _') to 'const HcalPedestals *' for 1st argument
  void setData (const HcalPedestals_ fItem) {mPedestals = fItem; mCalibSet = nullptr;}
       ^

bsunanda · 2016-08-19T00:31:13Z

@cmsbuild Please test

cmsbuild · 2016-08-19T00:53:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14596/console

cmsbuild · 2016-08-19T00:53:23Z

Pull request #15521 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

cmsbuild · 2016-08-19T01:41:14Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-08-19T01:41:31Z

-1

Tested at: 126794c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15521/14596/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

                 from /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/ComponentFactory.h:28,
                 from /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/ModuleFactory.h:26,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-2300/src/CalibCalorimetry/HcalTPGEventSetup/src/HcalTPGCoderULUT.cc:26:
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/DependentRecordImplementation.h: In instantiation of 'const DepRecordT& edm::eventsetup::DependentRecordImplementation::getRecord() const [with DepRecordT = HcalRecNumberingRecord; RecordT = HcalDbRecord; ListT = boost::mpl::vector]':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-2300/src/CalibCalorimetry/HcalTPGEventSetup/src/HcalTPGCoderULUT.cc:143:44:   required from here
/cvmfs/cms-ib.cern.ch/2016-34/slc6_amd64_gcc530/external/boost/1.57.0-giojec/include/boost/static_assert.hpp:78:41: error: static assertion failed: (! boost::is_same::value)
 #     define BOOST_STATIC_ASSERT( ... ) static_assert(**VA_ARGS**, #**VA_ARGS**)
                                         ^
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/DependentRecordImplementation.h:51:9: note: in expansion of macro 'BOOST_STATIC_ASSERT'
         BOOST_STATIC_ASSERT((! boost::is_same::value));
         ^

cmsbuild · 2016-08-19T18:11:19Z

+1
Tested at: f887c68
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15521/14604/summary.html

cmsbuild · 2016-08-19T19:04:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15521/14604/summary.html

cmsbuild · 2016-08-19T19:24:55Z

+1
Tested at: 8a23bed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15521/14605/summary.html

cmsbuild · 2016-08-19T20:13:00Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15521/14605/summary.html

bsunanda · 2016-08-22T15:41:45Z

@mmusich @ggovi Please review and approve this. We need these conditions for 2017 simulation and reconstruction

bsunanda · 2016-08-23T10:47:48Z

@mmusich @ggovi Sorry to remind again. Please review and approve this. We need these conditions for 2017 simulation and reconstruction

abdoulline · 2016-08-23T11:09:10Z

@mmusich @ggovi
Marco and Giacomo, we really are in a zeitnot situation with 2017 updates..

franzoni · 2016-08-23T15:49:23Z

+1

ggovi · 2016-08-23T15:51:33Z

+1

cmsbuild · 2016-08-23T15:52:52Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

davidlange6 · 2016-08-24T08:25:25Z

+1

cmsbuild added this to the Next CMSSW_8_1_X milestone Aug 18, 2016

cmsbuild added alca-pending db-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 18, 2016

Sunanda added 3 commits August 18, 2016 23:46

Add DB objects for HCAL TP

118cfbb

Resolve merge attempt

af843c4

Recover merging process

ce1cb26

bsunanda force-pushed the Run2-hcx89 branch from 1c27b72 to ce1cb26 Compare August 18, 2016 22:17

cmsbuild added tests-started and removed tests-pending labels Aug 18, 2016

cmsbuild added tests-rejected and removed tests-started labels Aug 18, 2016

Some more missed out changes

126794c

cmsbuild added tests-pending and removed tests-rejected labels Aug 19, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 19, 2016

cmsbuild added the tests-started label Aug 19, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 19, 2016

cmsbuild added tests-approved comparison-pending and removed comparison-available tests-started labels Aug 19, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 19, 2016

cmsbuild added alca-approved and removed alca-pending labels Aug 23, 2016

cmsbuild added fully-signed db-approved and removed db-pending pending-signatures labels Aug 23, 2016

cmsbuild added orp-approved and removed orp-pending labels Aug 24, 2016

cmsbuild merged commit c232732 into cms-sw:CMSSW_8_1_X Aug 24, 2016

matz-e mentioned this pull request Sep 22, 2016

Use database objects for HCAL 2017 TP #15945

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-hcx89 Add DB objects for HCAL TP #15521

bsunanda:Run2-hcx89 Add DB objects for HCAL TP #15521

bsunanda commented Aug 18, 2016 •

edited

cmsbuild commented Aug 18, 2016

bsunanda commented Aug 18, 2016

cmsbuild commented Aug 18, 2016 •

edited

cmsbuild commented Aug 18, 2016

cmsbuild commented Aug 18, 2016

bsunanda commented Aug 19, 2016

cmsbuild commented Aug 19, 2016 •

edited

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

bsunanda commented Aug 22, 2016

bsunanda commented Aug 23, 2016

abdoulline commented Aug 23, 2016

franzoni commented Aug 23, 2016

ggovi commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

davidlange6 commented Aug 24, 2016

bsunanda:Run2-hcx89 Add DB objects for HCAL TP #15521

bsunanda:Run2-hcx89 Add DB objects for HCAL TP #15521

Conversation

bsunanda commented Aug 18, 2016 • edited

cmsbuild commented Aug 18, 2016

bsunanda commented Aug 18, 2016

cmsbuild commented Aug 18, 2016 • edited

cmsbuild commented Aug 18, 2016

cmsbuild commented Aug 18, 2016

bsunanda commented Aug 19, 2016

cmsbuild commented Aug 19, 2016 • edited

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

cmsbuild commented Aug 19, 2016

bsunanda commented Aug 22, 2016

bsunanda commented Aug 23, 2016

abdoulline commented Aug 23, 2016

franzoni commented Aug 23, 2016

ggovi commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

davidlange6 commented Aug 24, 2016

bsunanda commented Aug 18, 2016 •

edited

cmsbuild commented Aug 18, 2016 •

edited

cmsbuild commented Aug 19, 2016 •

edited