Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ecalLaserCorr filter for the 2016 #15609

Merged

Conversation

mariadalfonso
Copy link
Contributor

Problem discussed in hn https://hypernews.cern.ch/HyperNews/CMS/get/ecal-performance/885/1.html

New cuts from D.Petyt.

  1. the EB maximum laser correction can be reduced. There should be no "well-behaved" channels in EB with a correction larger than 2.0
  2. the EE maximum laser correction must be increased, given the larger irradiation experienced in 2016. The previous threshold of 8 for the EE laser correction, large as it is, would likely create some false positives in the innermost eta rings of EE if applied to the most recent data.

For RECO, theEcalChannelStatus tag that masks the offending channel in EB for the entire 2016 dataset. In that case, the channel will be suppressed and no additional filter is needed.

This filter will be in the miniAOD and should be applied in analysis using the prompt-reco and in case re-reco doens't happen in favour of a re-miniAOD

@zdemirag @schoef

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mariadalfonso for CMSSW_8_1_X.

It involves the following packages:

RecoMET/METFilters

@cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 25, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14739/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 25, 2016

+1

For #15609 c94b173

Small adjustment to the ECAL laser correction filter.

#15610 is the 80X version of this PR.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-25-1100 show no significant differences.

@davidlange6 davidlange6 merged commit 6b40e9e into cms-sw:CMSSW_8_1_X Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants