Fix posftix and scheduled mode issue in the runMETUncertainty tool (Copy of the original #14606) #15616

mmarionncern · 2016-08-26T11:06:24Z

Identical to the original #14606 PR that was messed up when solving conflicts appeared during the holding time.

cmsbuild · 2016-08-26T11:08:22Z

A new Pull Request was created by @mmarionncern for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @gpetruc, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-08-26T13:08:59Z

@cmsbuild please test

cmsbuild · 2016-08-26T13:09:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14749/console

cmsbuild · 2016-08-26T14:51:11Z

+1
Tested at: 28d218c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15616/14749/summary.html

cmsbuild · 2016-08-26T15:51:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15616/14749/summary.html

slava77 · 2016-08-26T20:07:34Z

PhysicsTools/PatAlgos/python/cleaningLayer1/tauCleaner_cfi.py

@@ -8,7 +8,7 @@
        'tauID("decayModeFinding") > 0.5 &'
        ' tauID("byLooseCombinedIsolationDeltaBetaCorr3Hits") > 0.5 &'
        ' tauID("againstMuonTight3") > 0.5 &'
-        ' tauID("againstElectronVLooseMVA6") > 0.5'
+        ' tauID("againstElectronVLooseMVA5") > 0.5'


this should be switched back to MVA6
see #14596

@mmarionncern
it would be better to git rebase -i and remove the commit that edits this file

cmsbuild · 2016-08-28T17:30:31Z

Pull request #15616 was updated. @cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please check and sign again.

mariadalfonso · 2016-08-28T17:31:39Z

@slava77 removed the unneeded commit on the tau - config

slava77 · 2016-08-28T21:49:49Z

@cmsbuild please test
the comparisons got stuck, apparently

cmsbuild · 2016-08-28T21:50:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14785/console

cmsbuild · 2016-08-28T23:17:53Z

+1
Tested at: b5f0210
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15616/14785/summary.html

cmsbuild · 2016-08-28T23:51:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15616/14785/summary.html

slava77 · 2016-08-29T04:40:07Z

+1

for #15616 b5f0210

changes are the same as in the previously signed Fix posftix and scheduled mode issue in the runMETUncertainty tool #14606 c9a634f ... that PR was put on hold until rereco campaign is in order. The code changes are the same as in Fix posftix and scheduled mode issue in the runMETUncertainty tool #14608 which was in 81X since a few months already.
jenkins tests pass and comparisons with baseline show no differences (the MET uncertainty variables are still not monitored).

slava77 · 2016-08-29T11:41:03Z

hold

as with the previous (identical) iteration of this PR, there are changes in miniAOD which will go in once the rereco release is built.

cmsbuild · 2016-08-29T11:41:23Z

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

slava77 · 2016-09-06T14:18:25Z

-1
superseded by #15600
@mariadalfonso please double-check

mariadalfonso · 2016-09-07T09:25:43Z

@slava77 @davidlange6
not sure this is #15616 superseeded by the #15600

slava77 · 2016-09-07T11:07:21Z

@mariadalfonso
can you check if it is?
Visually, the same code is in #15600
Also, I checked that 81X version of PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py (the only file modified here) is the same in #15600
This PR has fewer edits.

I see that this PR would have merge conflicts anyways
https://github.com/cms-sw/cmssw/compare/CMSSW_8_0_X...cms-met:MM_Fix_230516_v3_duplicata?expand=1

mariadalfonso · 2016-09-07T11:53:11Z

@slava77
this PR (#15616) correspond to the #14608 that is in the 81 already
#15600 correspond to the #15565

i will check and solve the conflict (by today RECO meeting)

slava77 · 2016-09-07T11:58:12Z

On 9/7/16 4:53 AM, mariadalfonso wrote:

@slava77 https://github.com/slava77

this PR (#15616 #15616) correspond
to the #14608 #14608 that is in
the 81 already
#15600 #15600 correspond to the
#15565 #15565

i will check and solve the conflict (by today RECO meeting)

Thanks.

If any non-trivial edits from runMETCorrectionsAndUncertainties.py
are missing,
then something must be wrong, because they would be missing from 81X as well
(see my earlier message about runMETCorrectionsAndUncertainties.py being
the same in 81X and 80X+15600)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15616 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbo6kV3ZA4-rbgOR7PvdC5pXRk0jMks5qnqWogaJpZM4Jt-UJ.

mariadalfonso · 2016-09-07T18:03:42Z

@slava77 I confirm that this PR doens't add anything on top of the IB CMSSW_8_0_X_2016-09-07-1100. So good that is already closed

mmarionncern mentioned this pull request Aug 26, 2016

Fix posftix and scheduled mode issue in the runMETUncertainty tool #14606

Closed

cmsbuild added this to the Next CMSSW_8_0_X milestone Aug 26, 2016

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 26, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 26, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 26, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 26, 2016

slava77 reviewed Aug 26, 2016
View reviewed changes

matthieu added 3 commits August 28, 2016 19:27

fix postfix issue and scheduled mode

70e34a1

add protection for AOD processing

692b7e9

soften protection against duplicated modules

b5f0210

mariadalfonso force-pushed the MM_Fix_230516_v3_duplicata branch from 28d218c to b5f0210 Compare August 28, 2016 17:30

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Aug 28, 2016

cmsbuild added the tests-approved label Aug 28, 2016

cmsbuild added tests-pending tests-started and removed tests-approved tests-pending labels Aug 28, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 28, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 28, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 29, 2016

cmsbuild added the hold label Aug 29, 2016

slava77 mentioned this pull request Aug 30, 2016

possible 80X backports (terminated on 8_0_20) slava77/cmssw#93

Closed

mariadalfonso mentioned this pull request Sep 1, 2016

Puppi MET and MET significance fixes in the MET tool (80X) #15600

Merged

cmsbuild added reconstruction-rejected and removed reconstruction-approved labels Sep 6, 2016

davidlange6 closed this Sep 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix posftix and scheduled mode issue in the runMETUncertainty tool (Copy of the original #14606) #15616

Fix posftix and scheduled mode issue in the runMETUncertainty tool (Copy of the original #14606) #15616

mmarionncern commented Aug 26, 2016

cmsbuild commented Aug 26, 2016

slava77 commented Aug 26, 2016

cmsbuild commented Aug 26, 2016 •

edited

cmsbuild commented Aug 26, 2016

cmsbuild commented Aug 26, 2016

slava77 Aug 26, 2016

slava77 Aug 26, 2016

cmsbuild commented Aug 28, 2016

mariadalfonso commented Aug 28, 2016

slava77 commented Aug 28, 2016

cmsbuild commented Aug 28, 2016 •

edited

cmsbuild commented Aug 28, 2016

cmsbuild commented Aug 28, 2016

slava77 commented Aug 29, 2016

slava77 commented Aug 29, 2016

cmsbuild commented Aug 29, 2016

slava77 commented Sep 6, 2016

mariadalfonso commented Sep 7, 2016

slava77 commented Sep 7, 2016

mariadalfonso commented Sep 7, 2016

slava77 commented Sep 7, 2016

mariadalfonso commented Sep 7, 2016

Fix posftix and scheduled mode issue in the runMETUncertainty tool (Copy of the original #14606) #15616

Fix posftix and scheduled mode issue in the runMETUncertainty tool (Copy of the original #14606) #15616

Conversation

mmarionncern commented Aug 26, 2016

cmsbuild commented Aug 26, 2016

slava77 commented Aug 26, 2016

cmsbuild commented Aug 26, 2016 • edited

cmsbuild commented Aug 26, 2016

cmsbuild commented Aug 26, 2016

slava77 Aug 26, 2016

Choose a reason for hiding this comment

slava77 Aug 26, 2016

Choose a reason for hiding this comment

cmsbuild commented Aug 28, 2016

mariadalfonso commented Aug 28, 2016

slava77 commented Aug 28, 2016

cmsbuild commented Aug 28, 2016 • edited

cmsbuild commented Aug 28, 2016

cmsbuild commented Aug 28, 2016

slava77 commented Aug 29, 2016

slava77 commented Aug 29, 2016

cmsbuild commented Aug 29, 2016

slava77 commented Sep 6, 2016

mariadalfonso commented Sep 7, 2016

slava77 commented Sep 7, 2016

mariadalfonso commented Sep 7, 2016

slava77 commented Sep 7, 2016

mariadalfonso commented Sep 7, 2016

cmsbuild commented Aug 26, 2016 •

edited

cmsbuild commented Aug 28, 2016 •

edited