Extension of PAT TauPFEssential event content to be able to run anti-electron discriminators in miniAOD input #15747
Conversation
…he calculation of the MVA based anti-electron discriminator on miniAOD input
…pog_miniAOD-extension-antie
|
A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_1_X. It involves the following packages: DataFormats/PatCandidates @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -150,7 +150,7 @@ | |||
| </class> | |||
| <class name="std::vector<pat::tau::TauCaloSpecific>" /> | |||
| <class name="pat::tau::TauPFEssential" ClassVersion="12"> | |||
| <version ClassVersion="12" checksum="3865233356" /> | |||
| <version ClassVersion="12" checksum="1052833547" /> | |||
There was a problem hiding this comment.
this should be a new version, because #15731 is already in the realease
There was a problem hiding this comment.
this has been corrected
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
…two ordinary for loops to tidy up memory consumption
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
@roger-wolf |
|
file size in miniAOD increases. On 70 events of ttbar PU35 wf 25202.0 the increase is ~130 bytes/event. This should decrease with more events given some compression. The values are floats. So, compression will not make this much smaller. |
This includes minimal extensions to the TauPFEssential class in DataFormats/PatCandidates to be able to run the tau anti-electron MVA discriminator in miniAOD input. The variables in question are:
this comes as an anticipated addition to the pull request #15731 which allowed re-running only of the MVA based tau isolation and ID discriminator in the first place. The addition to the event content has been discussed in todays XPOG meeting (*). Usual tests have been applied without any occurence of showstoppers so far.
Once this PR is also integrated successfully the plan is close in time to backport it to 80X to have this essential additions to the miniAOD event content available from the 80X RERECO campaign.
Cheers,
Roger
(*)
https://indico.cern.ch/event/565391/