Better module depencency cycle finding #15981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now model Path and EndPath dependencies by having a unique graph vertex at the end of each Path, have TriggerResults depend on those verticies and then have unique graph verticies at the front of each EndPath with those vertices dependent upon TriggerResults.
Previously, if a module we have a consumes dependency on appeared earlier in a Path we would assume the found cycle was a false positive. Now we make sure that the cycle does not depend on modules which are even earlier in the Path.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_DEVEL_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_DEVEL_X IBs after it passes the integration tests. |
|
@smuzaffar this should stop the IB RelVal timeout problems (or at least some of them) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds more cases of true module dependency cycles which lead to unrunnable schedules.