Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better module depencency cycle finding #15981

Merged
merged 2 commits into from Sep 26, 2016
Merged

Better module depencency cycle finding #15981

merged 2 commits into from Sep 26, 2016

Commits on Sep 25, 2016

  1. Better handling of Path and EndPath dependencies 

    Now model Path and EndPath dependencies by having a unique graph vertex
at the end of each Path, have TriggerResults depend on those verticies
and then have unique graph verticies at the front of each EndPath with
those vertices dependent upon TriggerResults.
    @Dr15Jones
    Dr15Jones committed Sep 25, 2016
    Copy the full SHA
    2952b98 View commit details
    Browse the repository at this point in the history

  2. Better handling of cycles which contain modules earlier on the same Path 

    Previously, if a module we have a consumes dependency on appeared earlier in
a Path we would assume the found cycle was a false positive. Now we make sure
that the cycle does not depend on modules which are even earlier in the Path.
    @Dr15Jones
    Dr15Jones committed Sep 25, 2016
    Copy the full SHA
    807b6e1 View commit details
    Browse the repository at this point in the history