Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cross Path exceptions #16065

Merged
merged 4 commits into from Oct 2, 2016
Merged

Handle cross Path exceptions #16065

merged 4 commits into from Oct 2, 2016

Commits on Oct 1, 2016

  1. PuttableProductResolver gives wait task to Module 

    In order to handle the case where a module does not put a data
product, e.g. because of an exception, we still need to release
any modules waiting on the data product. We accomplish this by
having the PuttableProductResolver attach a waiting task to the
module to know when it has completed.
    @Dr15Jones
    Dr15Jones committed Oct 1, 2016
    Copy the full SHA
    e65dba2 View commit details
    Browse the repository at this point in the history

  2. Release waiting tasks on skipped modules 

    If all paths containing a module skip that module, be sure that
any tasks waiting on that module to complete are released.
    @Dr15Jones
    Dr15Jones committed Oct 1, 2016
    Copy the full SHA
    4f1eed8 View commit details
    Browse the repository at this point in the history

  3. Add unit test for concurrent paths and exceptions 

    Added a unit test for the case where a module on a path depends
on data from a module on another path and the other module throws
an exception.
    @Dr15Jones
    Dr15Jones committed Oct 1, 2016
    Copy the full SHA
    510d212 View commit details
    Browse the repository at this point in the history

  4. Code cleanup 

    Removed an unused function and an unused parameter from a function.
    @Dr15Jones
    Dr15Jones committed Oct 1, 2016
    Copy the full SHA
    575bdf6 View commit details
    Browse the repository at this point in the history