Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Eras.py imports from tracking #16086

Merged
merged 2 commits into from Oct 13, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Oct 4, 2016

This PR is a follow-up to #16001 by removing all imports of Eras.py from tracking.

Tested in CMSSW_8_1_X_2016-10-02-2300, no changes expected. I checked with workflows 4.22,5.1,8.0,25.0,135.13,135.4,136.731,140.53,1000.0,1001.0,1325.0,1325.1,1325.2,1325.3,1325.4,1330.0,10021.0,10024.0,10024.1,10024.2,10024.3,10024.4,10024.5,10424.0,10624.0,10824.0,20024.0,20024.1,20424.1,22424.0 (those include all tracking-specific workflows) that there are no changes in the configuration dumps.

@rovere @VinInn @kpedro88

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Configuration/StandardSequences
DQM/TrackingMonitorSource
RecoTracker/IterativeTracking
Validation/RecoTrack

@cvuosalo, @dmitrijus, @cmsbuild, @franzoni, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @hdelanno, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @fioriNTU, @wmtford, @gpetruc, @idebruyn, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Oct 4, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15514/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

@dmitrijus
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Oct 12, 2016

+1

for #16086 6ed0fa9

  • technical changes to refactor era imports
  • jenkins tests pass and comparisons show no differences
  • local check of short matrix workflows shows that expanded configs (python dumps) are the same

@makortel makortel deleted the removeEraImportsTracking branch February 12, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants