[80X] Temporary fix for multi-IOV input in MillePede

[ghellwig]

Backport of #16135

Adds a protection against multi-IOV input for MillePede to prevent issues like reported in the Tracker Alignment HN.

This is meant to be a temporary fix to quickly protect against this problem. The mid-term solution which is in preparation will properly handle multi-IOV input instead of prohibiting them.

[cmsbuild]

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_0_X.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15590/console

[cmsbuild]

-1

Tested at: 89b965a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16136/15590/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1001.0 step7

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step7_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

[mmusich]

----- Begin Fatal Exception 07-Oct-2016 13:53:05 CEST-----------------------
An exception of category 'DatabaseError' occurred while
   [0] Processing run: 165121
   [1] Calling global beginRun for module PCLTrackerAlProducer/'SiPixelAliPedeAlignmentProducer'
Exception Message:
@SUB=MillePedeAlignmentAlgorithm::initialize
Trying to apply TrackerAlignmentRcd with multiple IOVs in tag.
Validity range is 165088 - 165466
----- End Fatal Exception -------------------------------------------------
07-Oct-2016 13:53:05 CEST  Closed file file:PromptCalibProdSiPixelAli.root

shouldn't be the runAtPCL flag set to false True also here:

https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvester_cff.py#L35

[ghellwig]

@mmusich actually the other way around... apparently I just set it to True for the mille step and forgot it in the pede step when I introduced it...
Will fix that.

[mmusich]

actually the other way around... (?)

in here: https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/Alignment/CommonAlignmentProducer/python/ALCARECOPromptCalibProdSiPixelAli_cff.py#L100 is True and should be True also in the harvesting step

[ghellwig]

Yes, it should be True and not False, that's what I meant with the other way around. Sorry, if I was confusing.

[cmsbuild]

Pull request #16136 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15595/console

[cmsbuild]

+1
Tested at: 7890563
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16136/15595/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16136/15595/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh+HARVESTDR2

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1