Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel hit efficiency summary plot #16145

Merged
merged 2 commits into from Oct 14, 2016
Merged

Pixel hit efficiency summary plot #16145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c47e69
Added in a summary plot of average hit efficiency per sub detector fo…
leggat Oct 7, 2016
1c725f5
Updated to specifically ignore known problems and include other zero …
leggat Oct 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 16 additions & 4 deletions DQM/SiPixelMonitorClient/src/SiPixelActionExecutor.cc
View file
Open in desktop
Expand Up @@ -2092,6 +2092,9 @@ void SiPixelActionExecutor::fillEfficiencySummary(DQMStore::IBooker & iBooker, D
HitEfficiencySummary = iGetter.get("Pixel/HitEfficiencySummary");
//Now we will loop over the hit efficiency plots and fill it"
string hitEfficiencyPostfix[] = {"L1","L2","L3","Dp1","Dp2","Dm1","Dm2"};
std::vector<std::vector<float> > ignoreXBins = {{-4,2}, {4,4,-1,-3,3,-4,-3,-2,-1,-4,-3,-2,-1,1,-4}, {1,-4,1},{},{},{},{}};
std::vector<std::vector<float> > ignoreYBins = {{-9,-3},{1,16,1,-13,-13,-5,-5,-5,-5,-6,-6,-6,-6,-8,-8},{3,14,6},{},{},{},{}};

for (int i = 0; i < 7; i++){
string subdetName = "Endcap/";
if (i < 3) subdetName = "Barrel/";
Expand All @@ -2100,16 +2103,25 @@ void SiPixelActionExecutor::fillEfficiencySummary(DQMStore::IBooker & iBooker, D
MonitorElement * tempHitEffMap = iGetter.get(meName);
float totalEff = 0.;
int totalBins = 0;
TH1 * hitEffMap = tempHitEffMap->getTH1();
for (int xBin = 1; xBin < tempHitEffMap->getNbinsX() + 1; xBin++){
if (fabs(hitEffMap->GetXaxis()->GetBinCenter(xBin)) < 1.) continue;
for (int yBin = 1; yBin < tempHitEffMap->getNbinsY() + 1; yBin++){
if (tempHitEffMap->getBinContent(xBin,yBin) > 0.){
totalEff += tempHitEffMap->getBinContent(xBin,yBin);
totalBins++;
if (fabs(hitEffMap->GetYaxis()->GetBinCenter(yBin)) < 0.5) continue;
bool ignoreBin = false;
for (unsigned int j = 0; j < ignoreXBins[i].size(); j++){
if (hitEffMap->GetXaxis()->GetBinCenter(xBin) == ignoreXBins[i][j] && hitEffMap->GetYaxis()->GetBinCenter(yBin) == ignoreYBins[i][j]){
ignoreBin = true;
break;
}
}
if (ignoreBin) continue;
if (!(tempHitEffMap->getBinContent(xBin,yBin) < 0.)) totalEff += tempHitEffMap->getBinContent(xBin,yBin);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leggat do you really need to check if the bin content is not negative?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The efficiency bins are initialised to -1, so if they aren't filled they are negative. The reason for this line is so that if a bin not known to be bad hasn't been filled it is included in the average calculation with value of 0 instead of -1.

totalBins++;
}
}
float overalEff = 0.;
std::cout << i << " " << totalEff << " " << totalBins << std::endl;
// std::cout << i << " " << totalEff << " " << totalBins << std::endl;
if (totalBins > 0) overalEff = totalEff/float(totalBins);
HitEfficiencySummary->setBinContent(i+1,overalEff);
}
Expand Down