Feature Bits for 2017 HCAL HF TP #16156
Conversation
Allows for finer-grain overwriting, and still taking some parameters from the database.
Simplify code; Don't de- and then re-construct a dataframe, just pass it through. Unify the energy reconstruction in preparation for dual-anode readout.
|
A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_1_X. It involves the following packages: SimCalorimetry/HcalTrigPrimAlgos @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Again, @cmsbuild says comparisons are ready, but the linked page shows them as "Running"… |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
| auto adc_threshold = parameters->getADCThresholdHF(); | ||
| auto tdc_mask = parameters->getTDCMaskHF(); | ||
|
|
||
| if (override_parameters_.exists("ADCThresholdHF")) |
There was a problem hiding this comment.
Hi @matz-e - we can't do this sort of check for every digi. can you see who to move it to a once per job check. Thanks
| // finegrain[ibin] = (finegrain[ibin] || hcalfem->fineGrainbit(ADCShort, details.ShortDigi.id(), details.ShortDigi[ibin].capid(), ADCLong, details.LongDigi.id(), details.LongDigi[ibin].capid())); | ||
| // } | ||
| for (const auto& detail: details) { | ||
| if (detail.validity[idx] and HcalDetId(detail.digi.id()).ietaAbs() != 29) { |
There was a problem hiding this comment.
please document the magic number 29
cmsbuild
added
comparison-pending
l1-pending
pending-signatures
tests-pending
and removed
comparison-available
fully-signed
l1-approved
tests-approved
labels
|
Pull request #16156 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
Sits on top of #15945.