Use database objects for HCAL 2017 TP #15945
Conversation
Allows for finer-grain overwriting, and still taking some parameters from the database.
|
A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_1_X. It involves the following packages: SimCalorimetry/HcalTrigPrimAlgos @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@matz-e is this ready to test? @abdoulline will this have any GT issues? |
|
@kpedro88 I did have to uncomment lines in |
|
And to be a bit more clear, I'm not going to push more commits to this branch unless tests fail. |
|
We don't have (yet) TP conditions in none of regular GTs, so any attempt to access these conditions will fail, unless TP conditions are only used in 2017dev case. But, as you know, even in the latter case it will fail (with TP conditions -containing 2017dev GT) unless you uncomment DB callbacks... So for me it looks like a kind of stalemate situation. |
|
now that #16048 is merged, when the next IB comes out this PR can be rebased and the TP database conditions can be activated in HcalDbService. |
|
Will do. While I'm at it, I'll add some more changes/DB accesses. |
|
@matz-e you can rebase this (and any other db-related PRs) on |
|
actually, since this PR doesn't modify |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@rekovic, @mulhearn, @davidlange6 ping for pre13 |
|
@rekovic, @mulhearn, @davidlange6 ping again |
|
Actually #16156 contains these commits and is already approved by l1. |
Uses the database objects from #15646, #15521.
Allows to override single parameters instead of the whole set, using a PSet for the TP producer.