Added 2-D histogram of trigger tower flags vs Et; Revert FEStatus to run based: getting LS reports from FEMap instead.

[tanmaymudholkar]

This branch departs from 8.0.20, and contains the commits already proposed in #16112 and merged in 8.0.21; there shouldn't be a conflict while merging this PR into CMSSW_8_0_X branch. The main features:

• Add a new 2-D histogram to show the correlation between TT flags and Et deposited in a given trigger tower.
  • It is a backport of Added 2-D histogram of trigger tower flags vs Et. #16206 in CMSSW_8_1_X.
• Fix issue in offline DQM where FE Status Flag plots only display stats from last LS
  • Harvesting step in offline DQM causes LS-based plots to only keep stats from the last LS due to multi-threading, which affects all FE Status Flag plots in offline DQM since the introduction of PR Fix LS reports: only use RawData. #15411 (starting CMSSW 8_0_18 or ~run 279498).
  • Revert changes introduced in that PR: set ecalRawDataClient.MEs.QualitySummary and ecalRawDataTask.MEs.FEStatus to be run-based again.
  • To maintain functionality of GOOD channel reporting introduced in that PR, get RawData info instead from ecalRawDataTask.MEs.FEStatusErrMapByLumi (introduced later, in PR Duplicate key MEs for by lumi reset. #16112) which, by design, is already reset every LS, and is filled independently of the affected MEs above.
  • Originally in Revert FEStatus to run based. Get LS reports from FEMap instead. #16304: the new commit 13c7189 is a cherry-pick of f306f23 so it can be used online.
  • It is a backport of Revert FEStatus to run based. Get LS reports from FEMap instead. #16305 in CMSSW_8_1_X.

[cmsbuild]

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for CMSSW_8_0_X.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[dmitrijus]

+1
Did you cherry picked the commits? Or was it a merge-topic?
Once that older PR gets merged - we will see if this one gets a conflict :)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15743/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: c5efd04
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16205/15743/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16205/15743/summary.html

[tanmaymudholkar]

Hi @dmitrijus , I did a cherry-pick. (started out from base 8_0_20, cherry-picked both commits in #16112 , and added my own commit on top). I'll keep an eye on this, and if there is a conflict I can make a new PR -- thanks for letting me know.

[cmsbuild]

Pull request #16205 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[tanmaymudholkar]

Just for some additional background related to the update in this PR: a rather urgent fix was implemented by ECAL DQM which needed to be patched on the deployment server. In order to avoid conflicts, in consultation with @diguida , I updated this PR.

[diguida]

@tanmaymudholkar @dmitrijus to be crystal clear: the new commit 13c7189 is a cherry-pick of f306f23 included in #16304 . Given that this branch departs from 8.0.20, it can be used online.

[diguida]

@tanmaymudholkar can you please update the title of the PR to be like this:

Added 2-D histogram of trigger tower flags vs Et; Revert FEStatus to run based: getting LS reports from FEMap instead.

and the description:
This branch departs from 8.0.20, and contains the commits already proposed in #16112 and merged in 8.0.21; there shouldn't be a conflict while merging this PR into CMSSW_8_0_X branch. The main features:

• Add a new 2-D histogram to show the correlation between TT flags and Et deposited in a given trigger tower.
  • It is a backport of Added 2-D histogram of trigger tower flags vs Et. #16206 in CMSSW_8_1_X.
• Fix issue in offline DQM where FE Status Flag plots only display stats from last LS
  • Harvesting step in offline DQM causes LS-based plots to only keep stats from the last LS due to multi-threading, which affects all FE Status Flag plots in offline DQM since the introduction of PR Fix LS reports: only use RawData. #15411 (starting CMSSW 8_0_18 or ~run 279498).
  • Revert changes introduced in that PR: set ecalRawDataClient.MEs.QualitySummary and ecalRawDataTask.MEs.FEStatus to be run-based again
  • To maintain functionality of GOOD channel reporting introduced in that PR, get RawData info instead from ecalRawDataTask.MEs.FEStatusErrMapByLumi (introduced later, in PR Duplicate key MEs for by lumi reset. #16112) which, by design, is already reset every LS, and is filled independently of the affected MEs above.
  • Originally in Revert FEStatus to run based. Get LS reports from FEMap instead. #16304: the new commit 13c7189 is a cherry-pick of f306f23 so it can be used online.
  • It is a backport of Revert FEStatus to run based. Get LS reports from FEMap instead. #16305 in CMSSW_8_1_X.

[tanmaymudholkar]

@diguida Thanks for the suggestion. I have updated the title and description of the PR as you requested. Sorry for the confusion!

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16031/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: 13c7189
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16205/16031/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16205/16031/summary.html

[dmitrijus]

To clarify, this PR is the backport of #16305 and #16206 . Both are merged in 81x.

[davidlange6]

+1