Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LS reports: only use RawData. #15411

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Conversation

mbandrews
Copy link
Contributor

@mbandrews mbandrews commented Aug 10, 2016

Fix LS-based reporting in SummaryClient so that we correctly show % of good channels per LS in offline DQM

  • Set the monitor elements (1) ecalRawDataClient.MEs.QualitySummary, and (2) ecalRawDataTask.MEs.FEStatus to be run by lumi to correctly feed information to SummaryClient in offline DQM where these are normally only run at run end
  • Modify LS-based reports in SummaryClient to only use RawData quality as basis for "good" channels to keep memory usage low
  • Does not affect operation of SummaryClient in online DQM where these MEs are already produced every LS

Also, re-enable presample check in global quality summary.

In conjunction with 81X PR #15412

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_0_X.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2016

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants