Offline DQM L1T Muon CMSSW_8_1_X #16234
Conversation
|
A new Pull Request was created by @astakia for CMSSW_8_1_X. It involves the following packages: DQMOffline/L1Trigger @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
|
||
| verbose = cms.untracked.bool(False), | ||
| plotCfgs = cms.untracked.VPSet( | ||
| cms.untracked.PSet( dqmBaseDir = cms.untracked.string("L1T/Efficiency/Muons"), |
There was a problem hiding this comment.
DO NOT use tabs inside python files. Use 4 spaces.
Also, https://www.python.org/dev/peps/pep-0008/
|
I will wait for L1 signature before signing myself. |
|
Pull request #16234 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
|
@dmitrijus : tabs fixed (in the 8_0_X PR as well) |
|
Thanks, look fine! |
|
+1 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
Contains update of the Offline DQM L1T Muon efficiency code with the 2016 L1T variables (Stage2 Muons implementation).
The already made 8_0_X version of this pull request can be found here: PR #16233