New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HIN Dilepton] pPb Run DQMOffline for 80X #16289
Merged
davidlange6
merged 12 commits into
cms-sw:CMSSW_8_0_X
from
goni-zz:PADQMOffline_fixed_80X
Nov 10, 2016
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2f2fb93
cusomization and modification of DQMOffline for 2016 pPb run
goni-zz 8ee5619
add customization function for pPb run
goni-zz b3a2ebf
add customization function for pPb run
goni-zz b77d320
add customization function for pPb run
goni-zz 45f6e1e
add customization and modification of DQMOffline for 2016 pPb run
goni-zz c5719b5
rebase on #16394
goni-zz 6d9bf98
rebase on #16394
goni-zz 7ef6581
rebase on #16394
goni-zz ea904b2
same binwidth and mass range with 81X
goni-zz 0ce976c
same binwidth and mass range with 81X
goni-zz f7f033f
removed modifications of binning and mass range
goni-zz a0f98bd
regression/change
goni-zz File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an 81X PR with cleanup of this file?
Your currently pending PR
still has these modifications
https://github.com/cms-sw/cmssw/pull/16288/files#diff-59b63a7bb9dd6c9e55764b5600006fdbR34
BTW, as I mentioned in the other PR, if these are needed for HeavyIons scenario in general and should override what we have in the pp scenario defaults, then these edits have to stay here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slava77 , yeah We know about that.
we would better delete the line in 81X later(maybe end of pPb run).
should I delete the lines in 81X, right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the nominal policy is for everything aiming for 80X to first have an equivalent in 81X