New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ME0 re-digitizer module #16354
ME0 re-digitizer module #16354
Conversation
A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X. It involves the following packages: Configuration/Geometry @smuzaffar, @civanch, @Dr15Jones, @dmitrijus, @cvuosalo, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @franzoni, @slava77, @vanbesien, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@dildick @pietverwilligen |
-1 |
Pull request #16354 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
Pull request #16354 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
ME0ReDigiProducer was not registered. I tested WFs 20024.0 and 22424.0 again. Both were successful. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
Hi, please let me know if more work is need for this PR. Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Can this pull request be integrated, please? Thanks! |
+1 |
This module re-digitizes the ME0 pseudo digis. It smears and discretizes the timing position. It is included only in Phase2 digitization sequences.
Note: To be integrated after #16185. I will rebase on top of most recent build after #16185 is integrated.