-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reco material phaseI #16401
Reco material phaseI #16401
Conversation
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_8_1_X. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This PR will bring in the new recoMaterial tuning on top of the development/changes that have been added in #16338.
I locally merged it and started on top: I'm not sure what is the recommended/best procedure to follow in order to have both PRs integrated with the least possible conflicts.
Results of the tuning are ok, neither dramatic nor stricking, mostly because the material was already tuned in pre9.
You can find the usual MTV like plots for SingleMuon, Pt 10,5 here 1 and 2, respectively.
In general we could conclude that the Chi2 is somehow flattish, the number of missing outer hits decreases and the overall duplicate tracks go down (even if it's hard to judge on single muon samples).
The PR will also bring in all the mandatory C++ changes to the scripts used to derive the tuning: these are mandatory mostly for PhaseII, but since these code changes are not part of any workflow, I judged as ok to have them here. If Offline has problems with this approach, I formatted the history so that a single commit has all the required changes to the reconstruction material description: in case we could cherrypick only that one (in a separate PR).
Further testing on other samples is welcome in this case, to see if unforeseen changes will show up.