New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adedd Pixel Chip Capacitors materials to Phase II Pixel #16410
Conversation
A new Pull Request was created by @ghugo83 for CMSSW_8_1_X. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@ghudo83, why there are several identical material? Do we expect that these materials become different in future? In general, each new material bring an extra memory and CPU overhead, tiny but... |
Until now, there is one material mixture defined per tracker module. This is not necessary, it should be one material mixture defined per module type. You are totally right. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Näive question: do I understand correctly that since this is just for the Phase2 Pixel detector, it is not going to be propagated into |
Geometry/TrackerCommonData/data/PhaseII/FlatTracker and Geometry/TrackerCommonData/data/PhaseII/TiltedTracker are as you know plugged on a Phase I Pixel, so are not concerned by this. Today I will look at the Phase II OT which are in there and compare it with tkLayout as well. I will not look at the Phase I Pixel though. |
Great, thanks for the clarification. |
@ghugo83 would be able to produce the usual material vs eta plot, both with tkLayout and CMSSW, by selecting only a, let's say, cylinder with a given Rmax and Zmax ? This would allow you to do the comparison only in the pixel volume, up to the PS part of the barrel, for the whole tracker, ... |
yep sure, it is technically possible to look at the Pixel-only MB. This is even easy, because in the MB validation tool, you can select the LogicalVolume which one wants to isolate. For example, PixelBarrel and PixelForward. |
@boudoul @VinInn @rovere @ebrondol @venturia @ianna @alkemyst
Phase II Outer Tracker plugged on Phase II Pixel :
The Sim Material Budget in CMSSW had not been compared with the Material Budget in tkLayout yet.
Using similar changes than few of the commits which were done in #16401 , I extended the material budget validation tools to Phase II D4, and then compared the results with tkLayout.
The results were not too bad for a first-time check, but still, I found some discrepancy between CMSSW Sim MB and tkLayout MB. This is shown by the plot :
After some investigation, I found out that in one cfg file in tkLayout, the pixel chip capacitors materials is not assigned any CMSSW destination volume, whereas it should be added to the pixel description.
After doing the corresponding fix, I get a really good match between CMSSW and tkLayout, which tends to show this was the only significant issue.
The results are enclosed :
Summary :
This PR adds Pixel Chip Capacitors materials to Phase II Pixel description, and provides a match between CMSSW sim MB and tkLayout MB.