Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to pA skim names #16478

Merged
merged 1 commit into from Nov 7, 2016
Merged

Fix to pA skim names #16478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Configuration/Skimming/python/Skims_PA_cff.py
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the import of EventContentHeavyIons_cff is breaking the replay with 8_0_23.
Load of this files leads to override of all the standard EventContent (AOD, RAW, Reco, ) with their HI extensions.

Specifically, one of the overrides comes from RecoHiEgamma_EventContent_cff from RecoHiEgammaAOD, which has some ill-formed keep floatedmValueMap_*_*_*.
I would be still OK, if we were not running miniAOD: regular reco config setup purges the unnecessary ak8PFJetsCHSFilteredMass and its upstream ak8PFJetsCHSFiltered from the configuration when creating unscheduled configuration; but then miniAOD loads it back again in PhysicsTools/PatAlgos/python/slimming/applySubstructure_cff.py as process.load("RecoJets.JetProducers.ak8PFJetsCHS_groomingValueMaps_cfi") and there it loads only ak8PFJetsCHSFilteredMass and there is no downstream consumers of it in miniAOD and in this case this module should not run ... except that you have now inadvertently added keep floatedmValueMap_*_*_* which makes ak8PFJetsCHSFilteredMass runnable.
We didn't hit any of these fun parts with keep * in 2015 PbPb run because we did not run miniAOD.

If we are running the standard pp sequence with some small additions and edits of modules for pA needs, the FEVT event content has to be also the standard EventContent_cff.
So, please change the above

from Configuration.EventContent.EventContentHeavyIons_cff import FEVTEventContent

to

from Configuration.EventContent.EventContent_cff import FEVTEventContent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting a PR now with the change to pp event content. Btw, we shouldn't be producing mini-AOD, as far as I understood.

from Configuration.Skimming.PA_MinBiasSkim_cff import *
minBiasSkimPath = cms.Path( minBiasSkimSequence )
SKIMStreamMinBias = cms.FilteredStream(
SKIMStreamPAMinBias = cms.FilteredStream(
responsible = 'HI PAG',
name = 'PAMinBias',
paths = (minBiasSkimPath),
Expand All @@ -26,7 +26,7 @@

from Configuration.Skimming.PA_ZEESkim_cff import *
zEESkimPath = cms.Path( zEESkimSequence )
SKIMStreamZEE = cms.FilteredStream(
SKIMStreamPAZEE = cms.FilteredStream(
responsible = 'HI PAG',
name = 'PAZEE',
paths = (zEESkimPath),
Expand All @@ -40,7 +40,7 @@

from Configuration.Skimming.PA_ZMMSkim_cff import *
zMMSkimPath = cms.Path( zMMSkimSequence )
SKIMStreamZMM = cms.FilteredStream(
SKIMStreamPAZMM = cms.FilteredStream(
responsible = 'HI PAG',
name = 'PAZMM',
paths = (zMMSkimPath),
Expand Down