Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBHE M2-parameters: chi2, energy, pedSigma in M2 #16600

Merged
merged 6 commits into from Nov 21, 2016

Conversation

cmsbuild
Copy link
Contributor

This PR adjusts some of the M2 parameters.

  1. Follow up on the siPM parameters changes happened in GT 81X_upgrade2017_realistic_v23 and PR#16526 (i.e. pedestal width and 20GeV threshold both passed in fC)
  2. Adjust the chi2 threshold for the 1 vs 3 pulses

No effects expected in the run2 workflow

Validation plots in
http://dalfonso.web.cern.ch/dalfonso/dalfonso_siPM_M2_parameters.pdf
Automatically ported from CMSSW_8_1_X #16569 (original by @mariadalfonso).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

HLTrigger/Configuration
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mariadalfonso, @geoff-smith, @jalimena, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Nov 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16409/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Pull request #16600 was updated. @perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Nov 17, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16456/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16600/16456/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5

@slava77
Copy link
Contributor

slava77 commented Nov 21, 2016

+1

for #16600 419ae2c

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3aaed28 into cms-sw:CMSSW_9_0_X Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants