Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[90X] Fix misalignment tool for phase-1 (and phase-2) configurations. #16860

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Dec 5, 2016

Fixes behaviour if alignable names contain numbers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_9_0_X.

It involves the following packages:

Alignment/CommonAlignment

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ghellwig
Copy link
Author

ghellwig commented Dec 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16772/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

Comparison job queued.

@mmusich
Copy link
Contributor

mmusich commented Dec 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16860/16772/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6 davidlange6 merged commit a69fe89 into cms-sw:CMSSW_9_0_X Dec 6, 2016
cmsbuild added a commit that referenced this pull request Dec 9, 2016
…_81X

[81X] Fix misalignment tool for phase-1 (and phase-2) configurations (backport of #16860).
@ghellwig ghellwig deleted the fix-misalignment-tool-phase-1_90X branch December 21, 2016 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants