Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the missing dependency for plugin #17004

Merged
merged 1 commit into from Dec 13, 2016
Merged

add the missing dependency for plugin #17004

merged 1 commit into from Dec 13, 2016

Conversation

smuzaffar
Copy link
Contributor

RecoLocalTracker/SiPhase2Clusterizer/BuildFile.xml was dropped in #16815 which we did not noticed as the patch releases were getting its contents from full base release. This Pr adds the missing/removed dependencies

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16999/console Started: 2016/12/13 17:07

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_9_0_X.

It involves the following packages:

RecoLocalTracker/SiPhase2Clusterizer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @threus this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6 davidlange6 merged commit dfcb715 into cms-sw:CMSSW_9_0_X Dec 13, 2016
@slava77
Copy link
Contributor

slava77 commented Dec 13, 2016 via email

@smuzaffar
Copy link
Contributor Author

@slava77 , yes we have it for the code but not for the BuildFiles. I will fix it.

@cmsbuild
Copy link
Contributor

-1

Tested at: a1dd6ea

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a566413
2908752
0c9eaf9
4f05b52
dfdfe28
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17004/16999/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17004/16999/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17004/16999/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a566413
2908752
0c9eaf9
4f05b52
dfdfe28
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17004/16999/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17004/16999/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17004/16999/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFull_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants