Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ME0GeometryBuilder for baseline ME0 geometry #17175

Merged

Conversation

pietverwilligen
Copy link
Contributor

Use the newest ME0GeometryBuilder also for the M1 geometry (it was already in use for the M2 geometry where ME0 consist of 10 eta partitions). This PR provides the most detailed description of the ME0 Geometry also for the M1 geometry with a single eta partition. This PR is needed for studies the GEM Reco&Val group will perform on (eventually reprocessed by ourself) DIGI-RECO samples.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Jan 14, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6071ff6 into cms-sw:CMSSW_9_0_X Jan 16, 2017
@slava77
Copy link
Contributor

slava77 commented Jan 22, 2017

@pietverwilligen @calabria

I noticed that ME0 hits are now placed at 0 in local y instead of some not very realistic but still more practical ~flat distribution along the chamber length

all_oldvsnew_ttbar14tev2023d4wf21234p0c_me0detidme0rechitsownedrangemap_me0rechits_reco_obj_collection_data_localposition_y

If I'm not mistaken, this should mean that downstream ME0 reco is broken.
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_0_X_2017-01-13-1100+17175/17858/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/Muons_RecoMuonV_MultiTrack_extractMe0Muons.html

Please check and comment when should we expect a fix.

@pietverwilligen
Copy link
Contributor Author

I provided a bugfix: PR #17250

kpedro88 added a commit to kpedro88/cmssw that referenced this pull request Mar 13, 2017
…E0GeometryBuilder_ForPR_v1" (only for L1 TDR production)

This reverts commit 6071ff6, reversing
changes made to 66d4dd2.
cmsbuild added a commit that referenced this pull request Mar 15, 2017
Revert "Merge pull request #17175 from pietverwilligen/90X_NewME0GeometryBuilder_ForPR_v1" (only for L1 TDR production) [90X]
kkotov pushed a commit to kkotov/cmssw that referenced this pull request Apr 24, 2017
…E0GeometryBuilder_ForPR_v1" (only for L1 TDR production)

This reverts commit 6071ff6, reversing
changes made to 66d4dd2.
kkotov pushed a commit to kkotov/cmssw that referenced this pull request Apr 27, 2017
…E0GeometryBuilder_ForPR_v1" (only for L1 TDR production)

This reverts commit 6071ff6, reversing
changes made to 66d4dd2.
kkotov pushed a commit to kkotov/cmssw that referenced this pull request Apr 27, 2017
…E0GeometryBuilder_ForPR_v1" (only for L1 TDR production)

This reverts commit 6071ff6, reversing
changes made to 66d4dd2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants