Avoid freeing memory owned by TMVA::Reader

[dan131riley]

Older versions of TMVA::Reader didn't clean up classification methods, and so leaked memory. Some CMS code cleaned up the memory itself to avoid leaking. Starting with ROOT 6.07+, TMVA::Reader now cleans up after itself, so the CMS cleanups are resulting in double frees and potentially corrupted memory. This (rather ugly) PR patches all the places I could easily find to not assume ownership of the objects. More details are in issue #17256

[cmsbuild]

A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_9_0_X.

It involves the following packages:

EgammaAnalysis/ElectronTools
PhysicsTools/MVAComputer
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification
RecoJets/JetProducers
RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @TaiSakuma, @ahinzmann, @mmarionncern, @imarches, @makortel, @acaudron, @lgray, @jdolen, @ferencek, @Sam-Harper, @rafaellopesdesa, @nhanvtran, @gkasieczka, @schoef, @JyothsnaKomaragiri, @mverzett, @cbernet, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17417/console Started: 2017/01/24 22:38

[cmsbuild]

+1
Tested at: 3ca8416
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17266/17417/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17266/17417/summary.html

[slava77]

+1

for #17266 3ca8416

• implementation is in line with the description
• jenkins tests pass and comparisons with baseline show no differences
  • we started using ROOT 6.08/02 since about 10 days in 90X IBs; so, the new code branches are executed and appear OK

[slava77]

@davidlange6
please clarify if some extra work is needed here or are you just waiting for the missing analysis signature?
Thanks

[davidlange6]

its on my todo list (but not at the top)

…

On Jan 31, 2017, at 8:05 AM, Slava Krutelyov ***@***.***> wrote: @davidlange6 please clarify if some extra work is needed here or are you just waiting for the missing analysis signature? Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[monttj]

+1

[cmsbuild]

Pull request #17266 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17590/console Started: 2017/02/02 17:14

[cmsbuild]

+1
Tested at: 91be322
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17266/17590/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17266/17590/summary.html

[slava77]

+1

for #17266 91be322

• sign again after the support for ROOT version earlier than 6.07 was removed
• jenkins tests pass and comparisons show no differences