DataFormats/StdDictionaries : Changes needed to compile with macOS clang and libc++ #17351
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X. It involves the following packages: DataFormats/StdDictionaries @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
gartung
changed the title
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
| @@ -28,10 +28,6 @@ namespace DataFormats_StdDictionaries { | |||
| std::random_access_iterator_tag randaccitertag; | |||
| std::set<int> dummy19; | |||
| std::set<std::basic_string<char> > dummy20; | |||
| __gnu_cxx::new_allocator<char> dummy21; | |||
There was a problem hiding this comment.
It was related to missing ROOT dictionaries, ROOT5 stuff. There should be an issue in cmssw repository about that.
There was a problem hiding this comment.
The original PR: #57
Some notes I found in emails:
(13.4) We use edmClassStorageSize to iterate overall Reflex dictionaries and we find that we have ~200 errors and ~600-800 warnings coming
from ROOT. We think it might my partially responsible for ROOT failures on ARM. We fix part of them in CMSSW_7_0_X.
This was related to porting to ARMv7 and some failures.
These are a snippet from some old dump:
[..]
## std::allocator<char>
### Errors
~~~
Error in <TStreamerInfo::Build>: allocator<char>, unknown type: __gnu_cxx::new_allocator<char>
~~~
### Warnings
~~~
Error in <TStreamerInfo::Build>: allocator<char>, unknown type: __gnu_cxx::new_allocator<char>
~~~
## std::allocator<double>
### Errors
~~~
Error in <TStreamerInfo::Build>: allocator<double>, unknown type: __gnu_cxx::new_allocator<double>
~~~
### Warnings
~~~
Error in <TStreamerInfo::Build>: allocator<double>, unknown type: __gnu_cxx::new_allocator<double>
~~~
## std::allocator<int>
### Errors
~~~
Error in <TStreamerInfo::Build>: allocator<int>, unknown type: __gnu_cxx::new_allocator<int>
~~~
### Warnings
~~~
Error in <TStreamerInfo::Build>: allocator<int>, unknown type: __gnu_cxx::new_allocator<int>
~~~
## edm::RefToBase<reco::WMuNuCandidatePtr>
### Errors
~~~
Error in <TStreamerInfo::Build:>: edm::RefToBase<reco::WMuNuCandidatePtr>: edm::reftobase::BaseHolder<reco::WMuNuCandidatePtr>* has no streamer or dictionary, data member holder_ will not be saved
~~~
### Warnings
~~~
Error in <TStreamerInfo::Build:>: edm::RefToBase<reco::WMuNuCandidatePtr>: edm::reftobase::BaseHolder<reco::WMuNuCandidatePtr>* has no streamer or dictionary, data member holder_ will not be saved
~~~
## fakeMenu
### Errors
~~~
Error in <TStreamerInfo::Build>: The class "AlgoMap" is compiled and its base class "map<string,Algo>" is a collection and we do not have a dictionary for it, we will not be able to read or write this base class.
~~~
### Warnings
~~~
Error in <TStreamerInfo::Build>: The class "AlgoMap" is compiled and its base class "map<string,Algo>" is a collection and we do not have a dictionary for it, we will not be able to read or write this base class.
~~~
## pat::DiObjectProxy
### Errors
~~~
Error in <TStreamerInfo::Build:>: pat::DiObjectProxy: type_info* has no streamer or dictionary, data member type1_ will not be saved
Error in <TStreamerInfo::Build:>: pat::DiObjectProxy: type_info* has no streamer or dictionary, data member type2_ will not be saved
~~~
### Warnings
~~~
Error in <TStreamerInfo::Build:>: pat::DiObjectProxy: type_info* has no streamer or dictionary, data member type1_ will not be saved
Error in <TStreamerInfo::Build:>: pat::DiObjectProxy: type_info* has no streamer or dictionary, data member type2_ will not be saved
~~~
[..]
There was a problem hiding this comment.
ok, so we'll see it in the ibs if there is a problem..
|
+1 |
No description provided.