Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Polycone in Pixel Fwd #17387

Merged
merged 1 commit into from Feb 7, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 2, 2017

  • Use optimized Tub shape to represent one section Polycones

Comparison before (right) and after (left) snapshots:
screenshot 2017-02-02 11 56 22
screenshot 2017-02-02 11 57 58

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_9_0_X.

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @venturia, @VinInn, @ghugo83 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor Author

ianna commented Feb 2, 2017

@veszpv and @civanch - FYI

It would be nice to see if there is any difference in performance.

@ianna
Copy link
Contributor Author

ianna commented Feb 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17584/console Started: 2017/02/02 12:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Feb 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17387/17584/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d33c6cd into cms-sw:CMSSW_9_0_X Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants