Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LumiScalers collection to SiStripCalMinBias output #17419

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 6, 2017

Greetings,
with this PR we aim to add to the SiStripCalMinBias ALCARECO output products the LumiScalers and DcsStatus collections. This is done in view of streamlining several analyses in the context of the SiStrip DPG, (for example assessment of the hit efficiency as a function of instantaneous luminosity or PU, prepared in this PR #16540).
Change of data volume should be negligible, testing wf. 1000.0 in CMSSW_9_0_X_2017-02-05-2300 via:

runTheMatrix.py -l 1000.0 --command='-n 100'  
edmFileUtil SiStripCalMinBias.root

yields:

SiStripCalMinBias.root (1 runs, 1 lumis, 29 events, 4185563 bytes)

in the baseline release and

SiStripCalMinBias.root (1 runs, 1 lumis, 29 events, 4189455 bytes)

in the proposed branch, with an effective increase of ~135b/evt.

attn: @dimattia @jlagram @boudoul

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_0_X.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @threus, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ghellwig
Copy link

ghellwig commented Feb 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17626/console Started: 2017/02/06 11:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2017

@franzoni
Copy link

franzoni commented Feb 7, 2017

+1

Thanks @mmusich for providing extra size/even upfront

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 7, 2017
…nBias

Add LumiScalers collection to SiStripCalMinBias output
@cmsbuild cmsbuild merged commit bc681a3 into cms-sw:CMSSW_9_0_X Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants