CTPPS: miniAOD (resubmitted) #17424
CTPPS: miniAOD (resubmitted) #17424
Conversation
…cumented, class version 3.
…tomizeData section).
|
A new Pull Request was created by @jan-kaspar for CMSSW_9_0_X. It involves the following packages: DQM/CTPPS @monttj, @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Pull request #17424 was updated. @monttj, @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
In fc9b28c I've fixed merge conflicts appearing meanwhile. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1
|
|
Hi @jan-kaspar @slava77 - looks like this is causing lots of problems on old data. https://cms-sw.github.io/relvalLogDetail.html#slc6_amd64_gcc620;CMSSW_9_0_X_2017-02-26-0000 will revert for now. Please resubmit when fixed. |
|
On 2/26/17 4:25 AM, David Lange wrote:
Hi @jan-kaspar <https://github.com/jan-kaspar> @slava77
<https://github.com/slava77> - looks like this is causing lots of
problems on old data.
https://cms-sw.github.io/relvalLogDetail.html#slc6_amd64_gcc620;CMSSW_9_0_X_2017-02-26-0000
will revert for now. Please resubmit when fixed.
This might be a good reason to update the list of short matrix workflows
to have at least one with PAT on data.
#17633
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17424 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbvZ1m1C0cKG5UFXG_ZmOyghFU7f2ks5rgW9CgaJpZM4L4Jo4>.
|
|
@jan-kaspar |
|
I think you mean PAT data + no CTPPS in the run..Right. I guess that an alternative is that the CTPPS modules in the chain makes an empty collection instead of no collection when it finds that CTPPS is not in the run. (it looks like the unpackers and the RECO do this). Also things need to work on top of existing AOD(SIM), which is something I think we don't test very much (but probably should) |
|
unpackers and reco are still enabled by ctpps_2016 era |
|
Ok, so not in <=2015. Then the miniAOD setup needs to be consistent as you suggested..
… On Feb 26, 2017, at 6:18 PM, Slava Krutelyov ***@***.***> wrote:
unpackers and reco are still enabled by ctpps_2016 era
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
OK
Is the "true" a typo? We actually want to produce lite tracks for 2016 data. |
|
On 2/26/17 2:50 PM, jan-kaspar wrote:
I'd like to suggest to add a flag "doNothing" and if it's set, skip
all activity in the constructor and in the ::produce method.
OK
The "doNothing" flag can be set to true for ctpps_2016 era
Is the "true" a typo? We actually want to produce lite tracks for 2016 data.
sorry, indeed it's a typo; I wrote it correctly the first time around.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17424 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbvwhQaWujHrfoZTT_yASEYI-af3bks5rggG8gaJpZM4L4Jo4>.
|
|
The update has been resubmitted as #17650 . |
This PR is a follow up of #17162 after it has been reverted (#17265). It contains the same commits, plus an additional one inserting
ctppsLocalTrackLiteProducerin theminiAOD_customizeDatasection inPhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py- as proposed in #17282.runTheMatrix -l limitedgives