Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTPPS: miniAOD (second resubmission) #17701

Merged
merged 12 commits into from Mar 5, 2017
Merged

CTPPS: miniAOD (second resubmission) #17701

merged 12 commits into from Mar 5, 2017

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Mar 2, 2017

This is a continuation of #17424 after it has been reverted (#17630). It contains:

runTheMatrix -l limited gave

  • 14 14 13 11 6 0 0 0 tests passed, 2 0 0 0 0 0 0 0 failed
  • the two failures were DAS_ERROR in workflows 4.22 and 1001.0

Automatically ported from CMSSW_9_0_X #17650 (original by @CTPPS).
Please wait for a new IB (12 to 24H) before requesting to test this PR.

@jan-kaspar
CTPPSDetId scheme used consistently everywhere.
5e09a94
@jan-kaspar
CTPPSDetId scheme used consistently also in DQM.
b7b9170
@jan-kaspar
Added new data format: CTPPSLocalTrackLite.
5fdce4c 
Conflicts:
	DataFormats/CTPPSReco/src/classes.h
	DataFormats/CTPPSReco/src/classes_def.xml
@jan-kaspar
Added new producer: CTPPSLocalTrackLiteProducer.
0fb3b62
@jan-kaspar
CTPPSLocalTrackLiteProducer added to local reco sequence.
94860f8
@jan-kaspar
CTPPSLocalTrackLite added to FEVT, RECO and AOD event content.
b15bfd9 
Conflicts:
	RecoCTPPS/Configuration/python/RecoCTPPS_EventContent_cff.py
@jan-kaspar
CTPPSLocalTrackLite added to miniAOD event content.
386f4ae
@jan-kaspar
Class instead of struct, added default constructor, member methods do…
f944e0f 
…cumented, class version 3.

Conflicts:
	DataFormats/CTPPSReco/src/classes_def.xml
@jan-kaspar
ctppsLocalTrackLiteProducer included in miniAOD_tools.py (miniAOD_cus…
30888fe 
…tomizeData section).
@jan-kaspar
Added inhibition flag "doNothing".
4c85f47
@jan-kaspar
doNothing=true by default, set to false only for eras.ctpps_2016
9a84434
@jan-kaspar
Applies eras.ctpps_2016
fa8e156
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 2, 2017
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/CTPPS
DataFormats/CTPPSReco
PhysicsTools/PatAlgos
RecoCTPPS/Configuration
RecoCTPPS/TotemRPLocal

@monttj, @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 2, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18072/console Started: 2017/03/02 15:52
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18102/console Started: 2017/03/03 02:23

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

+1
Tested at: fa8e156
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17701/18102/summary.html

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17701/18102/summary.html

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2017

+1

for #17701 fa8e156

  • 91X version of bug fix since earlier submission of CTPPS: miniAOD (resubmitted) #17424 fc9b28c
    : 30888fe...fa8e156 to add configurable skip of execution in eras without CTPPS in order to not interfere with the miniAOD workflows there
  • jenkins tests pass (the test used includes not the 4.53 workflow which was previously failing and not tested at submission); comparisons with the baseline show no differences

davidlange6 added a commit that referenced this pull request Mar 5, 2017
@davidlange6
Merge pull request #17701 from CTPPS/ctpps_miniaod_resubmit2
c52e463 
CTPPS: miniAOD (second resubmission)
@davidlange6 davidlange6 merged commit c52e463 into cms-sw:master Mar 5, 2017
This was referenced Mar 6, 2017
Closed
Closed
@forthommel forthommel mentioned this pull request Mar 7, 2017
Merged
This was referenced Apr 6, 2017
Closed
Merged
@jan-kaspar jan-kaspar deleted the ctpps_miniaod_resubmit2 branch June 23, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available dqm-pending orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmsbuild @slava77 @davidlange6 @jan-kaspar