narrower anode time window switched to True #17521
Conversation
|
A new Pull Request was created by @nvoytish for CMSSW_9_0_X. It involves the following packages: RecoLocalMuon/CSCRecHitD @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
The tests are being triggered in jenkins. |
|
Reference for this mod is https://twiki.cern.ch/twiki/bin/viewauth/CMS/UFCSCLocalRecoStudy |
|
On 2/15/17 6:58 AM, ptcox wrote:
Reference for this mod is
https://twiki.cern.ch/twiki/bin/viewauth/CMS/UFCSCLocalRecoStudy
Thank you for the reference.
Does this configuration update propagate to cosmics modules as well?
If not, OK.
If yes, it probably shouldn't.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17521 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbnIvp5p5PmjB8EEul51WzSoTUdJ6ks5rcxKigaJpZM4MBnMU>.
|
|
Comparison job queued. |
|
No, it's OK for cosmics too. The detector is only ~2BX 'wide': if we
trigger on cosmics in the bottom half of the CSCs then there are two
time peaks - one at 0 from the hits in the bottom that trigger, and one
at -50 ns from hits in the top, i.e that appear 2BX early.
Slava Krutelyov wrote:
… On 2/15/17 6:58 AM, ptcox wrote:
> Reference for this mod is
> https://twiki.cern.ch/twiki/bin/viewauth/CMS/UFCSCLocalRecoStudy
Thank you for the reference.
Does this configuration update propagate to cosmics modules as well?
If not, OK.
If yes, it probably shouldn't.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#17521 (comment)>, or
> mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AEdcbnIvp5p5PmjB8EEul51WzSoTUdJ6ks5rcxKigaJpZM4MBnMU>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17521 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AE2Fnn7gkEGuk6VsISCoMb01JkD2NYIoks5rcxR_gaJpZM4MBnMU>.
|
|
Looking at the jenkins tests comparisons, I see no differences. The twiki is suggestive of some changes. Looking in detail: It looks like this PR is incomplete. @nvoytish @ptcox Thank you. |
|
That's pretty funny! Those UF people! They fooled me (us).
Well, looking on the bright side it confirms that with the window set as the original there are no differences.
Nikolay, could you change those 0, 15 to 6, 10 below?
Thanks,
Tim
…________________________________
From: Slava Krutelyov [notifications@github.com]
Sent: 17 February 2017 18:56
To: cms-sw/cmssw
Cc: Tim Cox; Mention
Subject: Re: [cms-sw/cmssw] narrower anode time window switched to True (#17521)
Looking at the jenkins tests comparisons, I see no differences.
Do we expect any (over a few hundred MC and data events, not all with muons)?
The twiki is suggestive of some changes.
Looking in detail:
the twiki says Use narrower wire time window for reconstruction, proposed wire time window is from 6-10
The configuration currently in the code is
CSCWireTimeWindowLow = cms.int32(0),
CSCWireTimeWindowHigh = cms.int32(15),
It looks like this PR is incomplete.
@nvoytish<https://github.com/nvoytish> @ptcox<https://github.com/ptcox>
please check and follow up
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#17521 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE2FnkfuwmkQM9S6Usm5bC9CtuHwGPnxks5rdd9bgaJpZM4MBnMU>.
|
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #17521 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
I changed the anode window to 6-10. Nikolay |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1
On the technical side, as seen in ttbar PU35 sample (10224), there is on average 10% decrease in CPU time of muon reconstruction modules (standalone reco times are down by 30%) for a total of about 1% decrease in the full reco time. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
+1 |
Use a narrower anode time window to build CSC recHits.
The flag CSCUseReducedWireTimeWindow switched to True.