Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "narrower anode time window switched to True" (91X fwd port of #17741) #17772

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Mar 3, 2017

This forward ports
#17741 70c303c
to 90X

It reverts #17521

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

RecoLocalMuon/CSCRecHitD

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ptcox, @bellan, @abbiendi, @jhgoh this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor Author

slava77 commented Mar 3, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18135/console Started: 2017/03/03 20:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

@slava77
Copy link
Contributor Author

slava77 commented Mar 3, 2017

+1

for #17772 ae0a56d

Here is an example plot of the CSC segment DOFs in 10-mu tests in jenkins (wf 10021)
all_oldvsnew_tenmue2017wf10021p0c_cscdetidcscsegmentsownedrangemap_cscsegments_reco_obj_collection_data_degreesoffreedom

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants