New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing subdet in Validation #17539
fix missing subdet in Validation #17539
Conversation
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_9_0_X. It involves the following packages: Alignment/OfflineValidation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild , please test |
The tests are being triggered in jenkins. |
@@ -127,6 +127,7 @@ void TrackerValidationVariables::fillHitQuantities(reco::Track const & track, st | |||
gVDirection = surface.toGlobal(lVDirection); | |||
|
|||
if (IntSubDetID == PixelSubdetector::PixelBarrel || | |||
IntSubDetID == PixelSubdetector::PixelEndcap || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VinInn
shouldn't the Forward Pixel topology require a different treatment of the local x and y orientations as in the other pre-existing method using using the trajectory: https://github.com/VinInn/cmssw/blob/1258c841813a3b05fa13c505931c119f1008f8d4/Alignment/OfflineValidation/src/TrackerValidationVariables.cc#L303-L323 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for noticing
@cmsbuild , please test |
The tests are being triggered in jenkins. |
ah fantastic, I was also fixing this bug , but was still on my laptob , didn't had the time to make the PR ... @VinInn was faster !! Grazie ! |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
trivial bug fixed
reported here
#17386 (comment)