RU CSC segment builder update

[nvoytish]

Some bugs omitted and optimization done.
The RU algo switched as the default CSC segment building algorithm.

[cmsbuild]

A new Pull Request was created by @nvoytish for CMSSW_9_0_X.

It involves the following packages:

RecoLocalMuon/CSCSegment

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ptcox, @bellan, @abbiendi, @jhgoh this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[nvoytish]

The talk related to this PR can be found here https://indico.cern.ch/event/611671/contributions/2472825/attachments/1411147/2158403/17_02_10-Voytishin_Palichik-CSCSegBuilder_status_before_updating_the_code-RECO_Meeting.pdf

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17838/console Started: 2017/02/17 13:59

[cmsbuild]

+1
Tested at: 66a843a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17543/17838/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17543/17838/summary.html

[slava77]

+1

for #17543 66a843a

• implementation in line with the description; the main feature is RU algo switched as the default CSC segment building algorithm
• jenkins tests pass and comparisons with the baseline show differences that start from cscSegments (reduction in number of segments per event mainly in short segments) and propagate downstream to muons, tracks (via muon iterations) and higher level objects.
• local tests with higher statistics and more targeted samples confirm behavior expected as presented in slides in the RECO and CSC meting(s) RU CSC segment builder update #17543 (comment). Some summary and details follow below.

In PU35 ttbar events (wf 10224)

• about 16% fewer cscSegments , mostly the shorter ones are gone
  
• about 16% less pf muons, a reduction mainly in the endcaps as expected (this reduction is balanced out by a matching increase in pf charged hadrons)
  

Muon 1TeV gun:

• a factor of 1.5 fewer CSC segments, with reduction mainly in worse quality and shorter segments

Multi-track validation plots show roughly unchanged performance for signal muons and some reduction in the muon fake rate.

• efficiency in 10 GeV muon gun sample (using 2K muons) is apparently down by o(0.1%)
• efficiency in 1 TeV muon gun sample is roughly unchanged (to within o(0.1%) )
• track parameter pulls look roughly the same in the core with some reduction in the tails (as expected from presented slides)

On the technical side, based on PU35 ttbar (10224)

• cscSegments time is up from 1 ms to 3ms per event, still rather negligible
• downstream muon-related module times are down (e.g. cosmics or displaced muons CPU is down by ~10%) for a total of about 0.5% reduction in total reco time

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[ptcox]

Thanks, Slava. Your summaries are excellent - very useful and informative. Is it OK to report them to a CSC Meeting? Tim

…

________________________________ From: Slava Krutelyov [notifications@github.com] Sent: 20 February 2017 21:08 To: cms-sw/cmssw Cc: Tim Cox; Mention Subject: Re: [cms-sw/cmssw] RU CSC segment builder update (#17543) +1 for #17543<#17543> 66a843a<66a843a> * implementation in line with the description; the main feature is RU algo switched as the default CSC segment building algorithm * jenkins tests pass and comparisons with the baseline show differences that start from cscSegments (reduction in number of segments per event mainly in short segments) and propagate downstream to muons, tracks (via muon iterations) and higher level objects. * local tests with higher statistics and more targeted samples confirm behavior expected as presented in slides in the RECO and CSC meting(s) #17543 (comment)<#17543 (comment)>. Some summary and details follow below. In PU35 ttbar events (wf 10224) * about 16% fewer cscSegments , mostly the shorter ones are gone [all_sign862vsorig_ttbar13tevpu2017wf10224p0c_cscdetidcscsegmentsownedrangemap_cscsegments__reco_obj_collection__data__degreesoffreedom]<https://cloud.githubusercontent.com/assets/4676718/23140030/43935eb8-f764-11e6-8fb1-47ecf7d3e896.png> * about 16% less pf muons, a reduction mainly in the endcaps as expected (this reduction is balanced out by a matching increase in pf charged hadrons) [all_sign862vsorig_ttbar13tevpu2017wf10224p0c_recopfcandidates_particleflow__reco_obj_eta57]<https://cloud.githubusercontent.com/assets/4676718/23140088/80e3a50c-f764-11e6-9e64-070605c6b659.png> Muon 1TeV gun: * a factor of 1.5 fewer CSC segments, with reduction mainly in worse quality and shorter segments [wf10009_cscseg_chi2]<https://cloud.githubusercontent.com/assets/4676718/23140012/23ae1a02-f764-11e6-994f-132fe42aa7c7.png> Multi-track validation plots show roughly unchanged performance for signal muons and some reduction in the muon fake rate. * efficiency in 10 GeV muon gun sample (using 2K muons) is apparently down by o(0.1%) * efficiency in 1 TeV muon gun sample is roughly unchanged (to within o(0.1%) ) * track parameter pulls look roughly the same in the core with some reduction in the tails (as expected from presented slides) On the technical side, based on PU35 ttbar (10224) * cscSegments time is up from 1 ms to 3ms per event, still rather negligible * downstream muon-related module times are down (e.g. cosmics or displaced muons CPU is down by ~10%) for a total of about 0.5% reduction in total reco time — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#17543 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE2FnvliKu5-gIUbtuYS_NRdOnKQkpQcks5refLJgaJpZM4MEBxe>.

[slava77]

On 2/20/17 12:22 PM, ptcox wrote: Thanks, Slava. Your summaries are excellent - very useful and informative. Is it OK to report them to a CSC Meeting?

Hi Tim, Sure, you can pass them along to the CSC community.

…

--slava

Tim ________________________________ From: Slava Krutelyov ***@***.*** Sent: 20 February 2017 21:08 To: cms-sw/cmssw Cc: Tim Cox; Mention Subject: Re: [cms-sw/cmssw] RU CSC segment builder update (#17543) +1 for #17543<#17543> 66a843a<66a843a> * implementation in line with the description; the main feature is RU algo switched as the default CSC segment building algorithm * jenkins tests pass and comparisons with the baseline show differences that start from cscSegments (reduction in number of segments per event mainly in short segments) and propagate downstream to muons, tracks (via muon iterations) and higher level objects. * local tests with higher statistics and more targeted samples confirm behavior expected as presented in slides in the RECO and CSC meting(s) #17543 (comment)<#17543 (comment)>. Some summary and details follow below. In PU35 ttbar events (wf 10224) * about 16% fewer cscSegments , mostly the shorter ones are gone [all_sign862vsorig_ttbar13tevpu2017wf10224p0c_cscdetidcscsegmentsownedrangemap_cscsegments__reco_obj_collection__data__degreesoffreedom]<https://cloud.githubusercontent.com/assets/4676718/23140030/43935eb8-f764-11e6-8fb1-47ecf7d3e896.png> * about 16% less pf muons, a reduction mainly in the endcaps as expected (this reduction is balanced out by a matching increase in pf charged hadrons) [all_sign862vsorig_ttbar13tevpu2017wf10224p0c_recopfcandidates_particleflow__reco_obj_eta57]<https://cloud.githubusercontent.com/assets/4676718/23140088/80e3a50c-f764-11e6-9e64-070605c6b659.png> Muon 1TeV gun: * a factor of 1.5 fewer CSC segments, with reduction mainly in worse quality and shorter segments [wf10009_cscseg_chi2]<https://cloud.githubusercontent.com/assets/4676718/23140012/23ae1a02-f764-11e6-994f-132fe42aa7c7.png> Multi-track validation plots show roughly unchanged performance for signal muons and some reduction in the muon fake rate. * efficiency in 10 GeV muon gun sample (using 2K muons) is apparently down by o(0.1%) * efficiency in 1 TeV muon gun sample is roughly unchanged (to within o(0.1%) ) * track parameter pulls look roughly the same in the core with some reduction in the tails (as expected from presented slides) On the technical side, based on PU35 ttbar (10224) * cscSegments time is up from 1 ms to 3ms per event, still rather negligible * downstream muon-related module times are down (e.g. cosmics or displaced muons CPU is down by ~10%) for a total of about 0.5% reduction in total reco time — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#17543 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE2FnvliKu5-gIUbtuYS_NRdOnKQkpQcks5refLJgaJpZM4MEBxe>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17543 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbokLJZYscGog7bgua3fFNXjaRi_xks5refX7gaJpZM4MEBxe>.

[davidlange6]

+1