Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSC RU segment algorithm tuned for ME0 #17687

Merged
merged 17 commits into from Mar 18, 2017

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Mar 2, 2017

Translated CSC RU algorithm (https://indico.cern.ch/event/578871/contributions/2345178/attachments/1358089/2053858/16_10_19-Voytishin_Palichik-CSCSegBuilderCSCWeekly.pdf) for use in ME0. It is not a direct port as some of the assumptions made for the CSC do not apply to ME0. It is now set as the default. Also updated standard segment algorithm to use the chamber as the coordinate reference frame.

Right now the default cfg parameters are for a 10 eta partition geometry and 768 strips...this will change once the geometry is finalized.
Automatically ported from CMSSW_9_0_X #17677 (original by @nickmccoll).
Please wait for a new IB (12 to 24H) before requesting to test this PR.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

RecoLocalMuon/GEMSegment

@cmsbuild, @cvuosalo, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 2, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18074/console Started: 2017/03/02 15:53
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18100/console Started: 2017/03/03 02:18

@nickmccoll
Copy link
Contributor

@slava77 Thanks for the info, do you want the 10k event memory profile to be with PU, or can that be w/o and just do the timing on a few events with PU? I am using pre4 GEN-SIM relvals to do this test, but the PU mixing is taking a while.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Pull request #17687 was updated. @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 17, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18534/console Started: 2017/03/17 23:41

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

@perrotta
Copy link
Contributor

+1
(as before the small fixes integrated with c3de46a)

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants