CSC RU builder widened roads and narrower anode time window switched to default

[nvoytish]

PR description:

This is a PR that omitts the customisation files and confirable parameter used for validation of the proposed changes in #25684 and #17772

Related presentation can be found here https://indico.cern.ch/event/784929/contributions/3265299/attachments/1777781/2890942/19_01_11-Voytishin_Palichik-CSCSegBuilder_proposal_RECO_meeting.pdf
The results of the validation can be found here:
https://hypernews.cern.ch/HyperNews/CMS/get/muon-object-validation/1287/1.html

[nvoytish]

@ptcox, you might be interested

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32948/21179

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32948/21179/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32948/21179/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32948/21180

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @nvoytish for master.

It involves the following packages:

RecoLocalMuon/CSCRecHitD
RecoLocalMuon/CSCSegment

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ptcox, @bellan, @abbiendi, @jhgoh this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-046035/12974/summary.html
COMMIT: b31a3a3
CMSSW: CMSSW_11_3_X_2021-02-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32948/12974/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8307 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 21198
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2729762
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jpata]

@nvoytish I ran the workflow 136.875_RunDoubleMuon2018C+RunDoubleMuon2018C+HLTDR2_2018+RECODR2_2018reHLT_Offline+HARVEST2018 with 100 events and two configurations to validate that the migration from the customisation functions is complete (separately of the physics validation you have linked above).

• reference, adding the customization functions at the end of step3_RAW2DIGI_L1Reco_RECO_EI_PAT_ALCA_DQM.py:

from RecoLocalMuon.CSCRecHitD.customRecHitBuilder import tightenAnodeTimes
from RecoLocalMuon.CSCSegment.customSegmentBuilder import widenRoads

process = tightenAnodeTimes(process)
process = widenRoads(process)

# Add early deletion of temporary data products to reduce peak memory need
from Configuration.StandardSequences.earlyDeleteSettings_cff import customiseEarlyDelete
process = customiseEarlyDelete(process)

• new, including this PR, not using any customization functions.

I observe don't observe any differences in the reco outputs that are monitored. The code changes also look OK to me. I will sign in a separate post.

[jpata]

+reconstruction

• removes customization functions from the muon code, new CSC configs are now enabled by default
• per CSC RU builder widened roads and narrower anode time window switched to default #32948 (comment), it looks like this is technically OK, no changes detected between the case of using the customization functions and this PR
• physics validation has been reported in the description, we expect more reconstructed muons, especially tracker and soft muons in data
• consequently, the reco outputs are expected to change in this PR (changes downstream from muons look minor)
• @cms-sw/operations-l2 this could be a good target for the next prerelease

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1
@cms-sw/pdmv-l2 the effect of this PR will be visible in the next pre-release campaign