Add new displaced muon gun #17775

dildick · 2017-03-04T14:08:04Z

This muon gun was designed for Phase-2 L1 trigger studies.

It fires muons (1 or 2 per event) with distributions flat in impact parameter d0(dxy), pT, eta and phi.
Each muon has its own production vertex. The production vertex of the extra muon is located at (-x, -y, -z) of the primary muon.
Along z-axis muon, muon vertex z is generated according to a gaussian.
Muon momentum along xy and z is generated such that muons are not flying back to the beamspot (pxy * Lxy > 0 and pz * Lz > 0)
Muons that are produced at too large vz but small Lxy are vetoed. Such muons are not likely to be triggered.

@dildick, @tahuang1991 @kpedro88

cmsbuild · 2017-03-04T14:08:19Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

Configuration/Generator
IOMC/ParticleGuns

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

perrozzi · 2017-03-04T22:47:16Z

please test

cmsbuild · 2017-03-04T22:47:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18144/console Started: 2017/03/04 23:48

cmsbuild · 2017-03-04T23:36:43Z

+1
Tested at: 23549f3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17775/18144/summary.html

cmsbuild · 2017-03-04T23:36:46Z

Comparison job queued.

cmsbuild · 2017-03-05T00:49:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17775/18144/summary.html

perrozzi · 2017-03-05T14:48:35Z

+1

cmsbuild · 2017-03-05T14:48:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

dildick · 2017-03-20T11:01:10Z

Can this code be integrated please?

govoni · 2017-03-20T11:02:42Z

+1

davidlange6 · 2017-03-21T11:00:15Z

IOMC/ParticleGuns/src/FlatRandomPtAndDxyGunProducer.cc

+      pz = pt * sinh(eta);
+      //vz = fabs(fRandomGaussGenerator->fire(0.0, LzWidth_/2.0));
+      float ConeTheta = ConeRadius_/ConeH_;
+      for (int j=0; j<100; j++){


Hi @dildick - so after 100 tries the loop gives up and throws at random? Sounds rather dangerous. Why should this not be 100^2 or ^3 tries before issuing some sort of error message?

ok, i gather this is caught below at line 115. but unclear why 100 is the right scale to avoid bias?

I'm not sure if we explicitly checked how many times a new vz needs to be thrown in order for it to be a good one. @tahuang1991: do you have an idea?

@davidlange6 we tested the code. 100 tries is more than enough to ensure that a vz is thrown such that it is in the region where we expect displaced muons to appear from physics signals that we can actually trigger on. On both sides of the beamspot we exclude vz's in cones close to the beamline and opening up towards high-eta. Muons that are generated here will most likely not be triggered on anyway.

cmsbuild · 2017-03-28T16:21:25Z

Pull request #17775 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

perrozzi · 2017-03-29T08:43:29Z

please test

cmsbuild · 2017-03-29T08:43:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18773/console Started: 2017/03/29 10:45

cmsbuild · 2017-03-29T09:29:18Z

+1
Tested at: a432179
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17775/18773/summary.html

cmsbuild · 2017-03-29T09:29:23Z

Comparison job queued.

kpedro88 · 2017-03-29T09:34:36Z

assign upgrade

cmsbuild · 2017-03-29T09:34:49Z

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2017-03-29T11:33:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17775/18773/summary.html

kpedro88 · 2017-03-29T12:31:36Z

+1

perrozzi · 2017-03-29T15:42:58Z

+1

cmsbuild · 2017-03-29T15:43:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

kpedro88 · 2017-04-02T12:22:39Z

@davidlange6 please merge

davidlange6 · 2017-04-03T11:30:54Z

+1

add displaced muon gun

23549f3

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 4, 2017

cmsbuild added comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Mar 4, 2017

dildick closed this Mar 4, 2017

dildick reopened this Mar 4, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 4, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 5, 2017

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Mar 5, 2017

davidlange6 reviewed Mar 21, 2017

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Mar 29, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 29, 2017

cmsbuild added the upgrade-pending label Mar 29, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 29, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 29, 2017

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Mar 29, 2017

cmsbuild added orp-approved and removed orp-pending labels Apr 3, 2017

cmsbuild merged commit eeb320b into cms-sw:master Apr 3, 2017

kpedro88 mentioned this pull request Apr 5, 2017

Register FlatRandomPtAndDxyGunProducer in Sealmodule #18222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new displaced muon gun #17775

Add new displaced muon gun #17775

dildick commented Mar 4, 2017 •

edited

cmsbuild commented Mar 4, 2017

perrozzi commented Mar 4, 2017

cmsbuild commented Mar 4, 2017 •

edited

cmsbuild commented Mar 4, 2017

cmsbuild commented Mar 4, 2017

cmsbuild commented Mar 5, 2017

perrozzi commented Mar 5, 2017

cmsbuild commented Mar 5, 2017

dildick commented Mar 20, 2017

govoni commented Mar 20, 2017

davidlange6 Mar 21, 2017

davidlange6 Mar 21, 2017

dildick Mar 21, 2017

dildick Mar 27, 2017 •

edited

cmsbuild commented Mar 28, 2017

perrozzi commented Mar 29, 2017

cmsbuild commented Mar 29, 2017 •

edited

cmsbuild commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

kpedro88 commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

kpedro88 commented Mar 29, 2017

perrozzi commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

kpedro88 commented Apr 2, 2017

davidlange6 commented Apr 3, 2017

Add new displaced muon gun #17775

Add new displaced muon gun #17775

Conversation

dildick commented Mar 4, 2017 • edited

cmsbuild commented Mar 4, 2017

perrozzi commented Mar 4, 2017

cmsbuild commented Mar 4, 2017 • edited

cmsbuild commented Mar 4, 2017

cmsbuild commented Mar 4, 2017

cmsbuild commented Mar 5, 2017

perrozzi commented Mar 5, 2017

cmsbuild commented Mar 5, 2017

dildick commented Mar 20, 2017

govoni commented Mar 20, 2017

davidlange6 Mar 21, 2017

Choose a reason for hiding this comment

davidlange6 Mar 21, 2017

Choose a reason for hiding this comment

dildick Mar 21, 2017

Choose a reason for hiding this comment

dildick Mar 27, 2017 • edited

Choose a reason for hiding this comment

cmsbuild commented Mar 28, 2017

perrozzi commented Mar 29, 2017

cmsbuild commented Mar 29, 2017 • edited

cmsbuild commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

kpedro88 commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

kpedro88 commented Mar 29, 2017

perrozzi commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

kpedro88 commented Apr 2, 2017

davidlange6 commented Apr 3, 2017

dildick commented Mar 4, 2017 •

edited

cmsbuild commented Mar 4, 2017 •

edited

dildick Mar 27, 2017 •

edited

cmsbuild commented Mar 29, 2017 •

edited