Extended simulation of neutron background #17799
Conversation
* Fix major overlaps
The shaft if 100m height,therefore the maximum radius of the OCMS volume was extended
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
| @@ -0,0 +1,33 @@ | |||
| import FWCore.ParameterSet.Config as cms | |||
|
|
|||
There was a problem hiding this comment.
Hi @civanch - please add some documentation of whats happening in this customize function and how it differs from the others.
Second, could it not just rely on NeutronBGforMuonsXS_cff.py for easier future maintenance?
|
-1 |
|
Pull request #17799 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again. |
|
@davidlange6 , comments are added to custom fragments. The common part is taken out into a common fragment. Unfortunately, by mistake updated cavern PR was peaked up here, so this PR will be closed and #17833 is already opened. |
By request of muon upgrade TDR, thermal neutron simulation extended two another Physics List used for this study. Time window extended from 0.1 second to 10 second.
Added extra header which will be used soon.
Should not affect mainstream simulation.