CTPPS: tracking for the diamond detector #17817
Conversation
Conflicts: DataFormats/CTPPSReco/interface/CTPPSDiamondRecHit.h DataFormats/CTPPSReco/src/classes.h DataFormats/CTPPSReco/src/classes_def.xml RecoCTPPS/TotemRPLocal/plugins/CTPPSDiamondRecHitProducer.cc
Conflicts: DataFormats/CTPPSReco/interface/CTPPSDiamondRecHit.h RecoCTPPS/TotemRPLocal/interface/CTPPSDiamondRecHitProducerAlgorithm.h RecoCTPPS/TotemRPLocal/plugins/CTPPSDiamondRecHitProducer.cc RecoCTPPS/TotemRPLocal/python/ctppsDiamondRecHitProducer_cfi.py RecoCTPPS/TotemRPLocal/src/CTPPSDiamondRecHitProducerAlgorithm.cc
Conflicts: DataFormats/CTPPSReco/interface/CTPPSDiamondRecHit.h
… it to the local tracks' EDProducer Conflicts: RecoCTPPS/TotemRPLocal/python/ctppsDiamondLocalReconstruction_cff.py RecoCTPPS/TotemRPLocal/test/diamonds_reco_cfg.py
… a single ctppsLocalReconstruction object ; moved floating point quantities in diamonds rechits from double to single precision ; bumped CTPPSDiamondRecHit class version from 2 to 3 Conflicts: RecoCTPPS/TotemRPLocal/python/ctppsDiamondLocalReconstruction_cff.py Conflicts: Configuration/StandardSequences/python/Reconstruction_cff.py RecoCTPPS/TotemRPLocal/python/ctppsDiamondLocalReconstruction_cff.py RecoCTPPS/TotemRPLocal/test/diamonds_reco_cfg.py
…ng a new one somewhere else) Conflicts: RecoCTPPS/TotemRPLocal/test/diamonds_reco_cfg.py
Conflicts: RecoCTPPS/Configuration/python/RecoCTPPS_EventContent_cff.py
…ed the module name to its products
|
A new Pull Request was created by @forthommel (Laurent Forthomme) for master. It involves the following packages: DataFormats/CTPPSReco @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
forthommel
changed the title
|
Comparison job queued. |
|
Pull request #17817 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
| @@ -68,10 +68,7 @@ CTPPSDiamondLocalTrackFitter::produce( edm::Event& iEvent, const edm::EventSetup | |||
| // workaround to retrieve the detset for 4-5 without losing the reference | |||
| edm::DetSet<CTPPSDiamondLocalTrack>& tracks45 = pOut->operator[]( id_45 ); | |||
|
|
|||
| // first remove all hits from previous event | |||
| trk_algo_45_.clear(); | |||
| trk_algo_56_.clear(); | |||
There was a problem hiding this comment.
are the algorithms created "clear" so that it's safe to have the clear() call only at the end?
|
The |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@davidlange6 - Did we address your review properly? |
|
Comparison job queued. |
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
+1 |
Track fitting procedure for the CTPPS diamond detector.
CTPPSDiamondLocalTrack, to be stored up to the AOD level.EDProducer(fit procedure described in slide 3 of this presentation) using theCTPPSDiamondRecHitcollection introduced in CTPPS: diamonds geometry and RecHits (from #17317) and making CTPPS geometry thread safe #17535 as an input.CTPPSDiamondRecHit, and used as a quality flag by the local track fitter.runTheMatrix.py -l limitedyielded:16 16 15 13 7 1 1 1 tests passed, 1 0 0 0 0 0 0 0 failedwith4.22_RunCosmics2011Afailing at step 0 (DAS_ERROR)