add PV monitoring @HLT #17996

mtosi · 2017-03-20T16:28:02Z

forward port of PR #17667
and
fix of PR #17693, which have some issues w/ merging

fix bug fix add ndof add PV monitoring@HLT for online DQM

@makortel

Ignore vertex collections for which the track refs are null (as done by @makortel in 336f8af) Print LogWarning once per stream in case of missing input collection (as done by @makortel in 0b5aad4) fix PVV@HLT fix

@Fake

fix VALIDATION step in workflows w/ HLT:@Fake fix fix fix DQM step as well !

fix add PAGs client fix fix handling of condDataValidation fix HARVESTING step in run1 no HLT Validation HARVESTING and no HLT DQM HARVESTING

cmsbuild · 2017-03-20T16:28:22Z

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
DQM/HLTEvF
DQMOffline/Configuration
DQMOffline/RecoB
DQMOffline/Trigger
Validation/Configuration
Validation/RecoVertex

@perrotta, @cmsbuild, @civanch, @dmitrijus, @silviodonato, @fwyzard, @mdhildreth, @fabozzi, @Martin-Grunewald, @franzoni, @kpedro88, @slava77, @GurpreetSinghChahal, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @Martin-Grunewald, @threus, @venturia, @battibass, @makortel, @acaudron, @jhgoh, @HuguesBrun, @ferencek, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan, @imarches, @calderona, @mverzett, @JyothsnaKomaragiri, @pvmulder this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

silviodonato · 2017-03-20T16:29:23Z

please test

cmsbuild · 2017-03-20T16:29:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18567/console Started: 2017/03/20 20:09

cmsbuild · 2017-03-20T20:52:44Z

+1
Tested at: 8ef1586
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17996/18567/summary.html

cmsbuild · 2017-03-20T20:52:47Z

Comparison job queued.

cmsbuild · 2017-03-20T23:09:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17996/18567/summary.html

perrotta · 2017-03-21T09:25:35Z

+1
(Mostly DQM, it only touches Reco through Validation)

fabozzi · 2017-03-21T09:49:23Z

+1

civanch · 2017-03-21T11:01:04Z

+1

dmitrijus · 2017-03-21T12:30:22Z

+1

Martin-Grunewald · 2017-03-22T07:50:32Z

Looks like this PR creates problems:

%MSG-w PrimaryVertexAnalyzer4PUSlimmed:   PrimaryVertexAnalyzer4PUSlimmed:hltPi\
xelPVanalysis 22-Mar-2017 08:08:21 CET  Run: 1 Event: 101
Skipping vertex collection: hltPixelVertices since it is missing.
%MSG
%MSG-w PrimaryVertexAnalyzer4PUSlimmed:   PrimaryVertexAnalyzer4PUSlimmed:hltPi\
xelPVanalysis 22-Mar-2017 08:08:21 CET  Run: 1 Event: 101
Skipping vertex collection: hltTrimmedPixelVertices since it is missing.
%MSG
----- Begin Fatal Exception 22-Mar-2017 08:08:21 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing Event run: 1 lumi: 3 event: 101
   [1] Running path 'prevalidation_step'
   [2] Prefetching for module PrimaryVertexAnalyzer4PUSlimmed/'hltPVanalysis'
   [3] Calling method for module VertexAssociatorByPositionAndTracksProducer/'v\
ertexAssociatorByPositionAndTracks4pixelTracks'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::AssociationMap<edm::OneToManyWithQualityGeneric<std::vec\
tor<TrackingParticle>,edm::View<reco::Track>,double,unsigned int,edm::RefProd<s\
td::vector<TrackingParticle> >,edm::RefToBaseProd<reco::Track>,edm::Ref<std::ve\
ctor<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::v\
ector<TrackingParticle>,TrackingParticle> >,edm::RefToBase<reco::Track> > >
Looking for module label: tpToHLTpixelTrackAssociation
Looking for productInstanceName:

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exc\
eption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe\
t in the configuration.

----- End Fatal Exception -------------------------------------------------

Martin-Grunewald · 2017-03-22T07:52:19Z

Or this one:

----- Begin Fatal Exception 22-Mar-2017 08:16:50 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing Event run: 1 lumi: 3 event: 103
   [1] Running path 'dqmofflineOnPAT_step'
   [2] Calling method for module PrimaryVertexMonitor/'hltVerticesPFFilterMonit\
oring'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Vertex>
Looking for module label: hltVerticesPFFilter
Looking for productInstanceName:

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exc\
eption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe\
t in the configuration.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Mar-2017 08:16:50 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing Event run: 1 lumi: 3 event: 102
   [1] Running path 'dqmofflineOnPAT_step'
   [2] Calling method for module PrimaryVertexMonitor/'hltVerticesPFFilterMonit\
oring'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Vertex>
Looking for module label: hltVerticesPFFilter
Looking for productInstanceName:

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exc\
eption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe\
t in the configuration.

Martin-Grunewald · 2017-03-22T07:53:25Z

It affects PRef and PIon (and the Fake*) HLT menus, which probably do not contain the module.
But as always, subsequent modules should NOT CRASH when the input collection is missing!

davidlange6 · 2017-03-22T07:56:32Z

yes, I was just seeing the same thing - will revert for now while this can be fixed.

…

On Mar 22, 2017, at 8:52 AM, Martin Grunewald ***@***.***> wrote: Or this one: ----- Begin Fatal Exception 22-Mar-2017 08:16:50 CET----------------------- An exception of category 'ProductNotFound' occurred while [0] Processing Event run: 1 lumi: 3 event: 103 [1] Running path 'dqmofflineOnPAT_step' [2] Calling method for module PrimaryVertexMonitor/'hltVerticesPFFilterMonit\ oring' Exception Message: Principal::getByToken: Found zero products matching all criteria Looking for type: std::vector<reco::Vertex> Looking for module label: hltVerticesPFFilter Looking for productInstanceName: Additional Info: [a] If you wish to continue processing events after a ProductNotFound exc\ eption, add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe\ t in the configuration. ----- End Fatal Exception ------------------------------------------------- ----- Begin Fatal Exception 22-Mar-2017 08:16:50 CET----------------------- An exception of category 'ProductNotFound' occurred while [0] Processing Event run: 1 lumi: 3 event: 102 [1] Running path 'dqmofflineOnPAT_step' [2] Calling method for module PrimaryVertexMonitor/'hltVerticesPFFilterMonit\ oring' Exception Message: Principal::getByToken: Found zero products matching all criteria Looking for type: std::vector<reco::Vertex> Looking for module label: hltVerticesPFFilter Looking for productInstanceName: Additional Info: [a] If you wish to continue processing events after a ProductNotFound exc\ eption, add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe\ t in the configuration. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

mtosi · 2017-03-22T08:23:25Z

opsi
can you please point me to the workflows which show these issues, please ?
I thought I had fixed them, but ....
thanks !

davidlange6 · 2017-03-22T08:26:06Z

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_1_X_2017-03-21-2300/pyRelValMatrixLogs/run/134.805_RunMET2015C+RunMET2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2/step3_RunMET2015C+RunMET2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2.log

mtosi · 2017-03-22T12:56:38Z

I'm confused :(
I ran
runTheMatrix.py -l 134.805 &
and I have

134.805_RunMET2015C+RunMET2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Mar 22 13:28:42 2017-date Wed Mar 22 13:05:20 2017; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

I'm in the branch

git branch
  CMSSW_9_1_X
  backport-attempt
  backport-from-CMSSW_9_0_X
  from-CMSSW_9_1_X_2017-03-20-1100
* pvMonitoring@HLT_91x

under

echo $CMSSW_BASE/
/afs/cern.ch/work/t/tosi/public/trackingHLT/DQM/cleanAREA/CMSSW_9_1_X_2017-03-20-1100/

davidlange6 · 2017-03-22T13:49:07Z

maybe your branch is not in a consistent state? You can try CMSSW_9_1_X_2017-03-21-2300 (not working in our tests, your PR in) CMSSW_9_1_X_2017-03-22-1100 (working in our tests, your PR out)

…

On Mar 22, 2017, at 1:56 PM, mia tosi ***@***.***> wrote: I'm confused :( I ran runTheMatrix.py -l 134.805 & and I have 134.805_RunMET2015C+RunMET2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Wed Mar 22 13:28:42 2017-date Wed Mar 22 13:05:20 2017; exit: 0 0 0 0 1 1 1 1 tests passed, 0 0 0 0 failed I'm in the branch git branch CMSSW_9_1_X backport-attempt backport-from-CMSSW_9_0_X from-CMSSW_9_1_X_2017-03-20-1100 * ***@***.***_91x under echo $CMSSW_BASE/ /afs/cern.ch/work/t/tosi/public/trackingHLT/DQM/cleanAREA/CMSSW_9_1_X_2017-03-20-1100/ — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

Dr15Jones · 2017-03-22T14:11:09Z

@wddgit Could be an interaction with the Task pull request.

davidlange6 · 2017-03-22T14:14:04Z

it didn't seem likely to me. but maybe you can confirm if there is a potential conflict

…

On Mar 22, 2017, at 3:11 PM, Chris Jones ***@***.***> wrote: @wddgit Could be an interaction with the Task pull request. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

wddgit · 2017-03-22T14:30:44Z

Just quickly skimming this PR, I cannot see anything I would expect to interact badly with the Tasks PR. At this point, I think the Tasks PR is unrelated to these failures. If you find more evidence pointing in that direction, ask and I will take a closer look.

This problem did start at the same point in time and the Tasks PR modifies a lot of the code that processes the python configurations so it reasonable to suspect it. On the hand, the Tasks PR mostly effects which modules are configured to run in unscheduled mode. It should not affect things that are put on Paths or EndPaths and it looks like the content in this PR is all on Paths or EndPaths.

mtosi · 2017-03-22T17:12:41Z

I've just done

cmsrel CMSSW_9_1_X_2017-03-22-1100
cd CMSSW_9_1_X_2017-03-22-1100/src/
cmsenv
git cms-merge-topic 17996

but I get
You are on branch from-CMSSW_9_1_X_2017-03-22-1100
From .

[new ref] -> merge-attempt
From https://github.com/cms-sw/cmssw
[new ref] refs/pull/17996/head -> cms-sw/refs/pull/17996/head
Switched to branch 'merge-attempt'
Already up-to-date.
Switched to branch 'from-CMSSW_9_1_X_2017-03-22-1100'
Checking out these packages: 0

what should I do ?
thanks

Dr15Jones · 2017-03-22T18:03:32Z

I think the problem you are encountering is the fact that the pull request was merged (and then reverted) and therefore git sees no reason to merge it again. Maybe it would be better to try to do a 'rebase' of your original branch onto the master branch

mtosi and others added 7 commits March 20, 2017 17:04

add validation of hltVerticesPFFilter collection

4b020f5

add PV monitoring @HLT

65b6eb3

add vertex monitoring @HLT to online DQM as well

e963377

fix bug fix add ndof add PV monitoring@HLT for online DQM

Ignore vertex collections for which the track refs are null

9c93787

Print LogWarning once per stream in case of missing input collection

ac7a383

Ignore vertex collections for which the track refs are null (as done by @makortel in 336f8af) Print LogWarning once per stream in case of missing input collection (as done by @makortel in 0b5aad4) fix PVV@HLT fix

add standardValidationNoHLT

34777d0

fix VALIDATION step in workflows w/ HLT:@Fake fix fix fix DQM step as well !

add main PAGs sequence for offline DQM

8ef1586

fix add PAGs client fix fix handling of condDataValidation fix HARVESTING step in run1 no HLT Validation HARVESTING and no HLT DQM HARVESTING

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 20, 2017

cmsbuild added comparison-pending dqm-pending hlt-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Mar 20, 2017

mtosi mentioned this pull request Mar 20, 2017

add PV monitoring @HLT #17693

Closed

cmsbuild added tests-started and removed tests-pending labels Mar 20, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 20, 2017

cmsbuild added hlt-approved and removed hlt-pending labels Mar 21, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 21, 2017

cmsbuild added pdmv-approved and removed pdmv-pending labels Mar 21, 2017

cmsbuild added simulation-approved and removed simulation-pending labels Mar 21, 2017

cmsbuild added dqm-approved and removed dqm-pending labels Mar 21, 2017

davidlange6 merged commit de8cd7c into cms-sw:master Mar 21, 2017

davidlange6 mentioned this pull request Mar 22, 2017

Revert "add PV monitoring @HLT" #18029

Merged

mtosi mentioned this pull request Mar 24, 2017

add PV monitoring @HLT #18074

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add PV monitoring @HLT #17996

add PV monitoring @HLT #17996

mtosi commented Mar 20, 2017 •

edited

cmsbuild commented Mar 20, 2017

silviodonato commented Mar 20, 2017

cmsbuild commented Mar 20, 2017 •

edited

cmsbuild commented Mar 20, 2017

cmsbuild commented Mar 20, 2017

cmsbuild commented Mar 20, 2017

perrotta commented Mar 21, 2017

fabozzi commented Mar 21, 2017

civanch commented Mar 21, 2017

dmitrijus commented Mar 21, 2017

Martin-Grunewald commented Mar 22, 2017

Martin-Grunewald commented Mar 22, 2017

Martin-Grunewald commented Mar 22, 2017 •

edited

davidlange6 commented Mar 22, 2017 via email

mtosi commented Mar 22, 2017

davidlange6 commented Mar 22, 2017

mtosi commented Mar 22, 2017

davidlange6 commented Mar 22, 2017 via email

Dr15Jones commented Mar 22, 2017

davidlange6 commented Mar 22, 2017 via email

wddgit commented Mar 22, 2017

mtosi commented Mar 22, 2017

Dr15Jones commented Mar 22, 2017

add PV monitoring @HLT #17996

add PV monitoring @HLT #17996

Conversation

mtosi commented Mar 20, 2017 • edited

cmsbuild commented Mar 20, 2017

silviodonato commented Mar 20, 2017

cmsbuild commented Mar 20, 2017 • edited

cmsbuild commented Mar 20, 2017

cmsbuild commented Mar 20, 2017

cmsbuild commented Mar 20, 2017

perrotta commented Mar 21, 2017

fabozzi commented Mar 21, 2017

civanch commented Mar 21, 2017

dmitrijus commented Mar 21, 2017

Martin-Grunewald commented Mar 22, 2017

Martin-Grunewald commented Mar 22, 2017

Martin-Grunewald commented Mar 22, 2017 • edited

davidlange6 commented Mar 22, 2017 via email

mtosi commented Mar 22, 2017

davidlange6 commented Mar 22, 2017

mtosi commented Mar 22, 2017

davidlange6 commented Mar 22, 2017 via email

Dr15Jones commented Mar 22, 2017

davidlange6 commented Mar 22, 2017 via email

wddgit commented Mar 22, 2017

mtosi commented Mar 22, 2017

Dr15Jones commented Mar 22, 2017

mtosi commented Mar 20, 2017 •

edited

cmsbuild commented Mar 20, 2017 •

edited

Martin-Grunewald commented Mar 22, 2017 •

edited