Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PV monitoring @HLT #17693

Closed
wants to merge 32 commits into from
Closed

add PV monitoring @HLT #17693

wants to merge 32 commits into from

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Mar 2, 2017

we were missing some vertex collection in the validation
and the monitoring for all collection (both online and offline)

this PR adds the validation and monitoring for vertex @HLT

there is a missing collection in the HLT output modules (hltVerticesPFFilter)
I opened the JIRA ticket #1201 for adding it

I'm currently running runTheMatrix -l limited
Automatically ported from CMSSW_9_0_X #17667 (original by @mtosi).
Please wait for a new IB (12 to 24H) before requesting to test this PR.

cmsbuild and others added 4 commits March 2, 2017 09:32
bsunanda:Run2-alca74 Make IsoTrack AlCaReco as well as tree makers to be equally useful for all possible isolation strategy
implement "plan 1" and sum SiPM rechits over all depths
Cumulative updates to HipPy scripting, TwoBodyDecay, Alignment/OfflineValidation and MuonAnalysis/MuscleFit macros
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/HLTEvF
DQMOffline/Trigger
Validation/RecoVertex

@perrotta, @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @felicepantaleo, @GiacomoSguazzoni, @jhgoh, @VinInn, @calderona, @HuguesBrun, @rovere, @mtosi, @rociovilar, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor

@mtosi
Please fix or close....

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 7, 2017

Pull request #17693 was updated. @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Mar 7, 2017

sorry the delay, but the issue w/ frontier and the weekend prevented to fix it sooner

there was a bug in the original PV monitoring code,
which is fixed, now

hope this PR is fine, now

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18205/console Started: 2017/03/07 13:52

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 7, 2017

-1

Tested at: 085be0e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17693/18205/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step3
runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

136.731 step3
runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

10024.0 step3
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

25202.0 step3
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 7, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@Martin-Grunewald
Copy link
Contributor

-1
merge conflicts

@cmsbuild
Copy link
Contributor Author

@Martin-Grunewald
Copy link
Contributor

-1
still merge conflicts

@cmsbuild
Copy link
Contributor Author

@silviodonato
Copy link
Contributor

Ciao Mia,
you still need to rebase this 91X PR (please have a look to https://github.com/cms-sw/cmssw/pull/17693/files).

no HLT Validation HARVESTING and no HLT DQM HARVESTING
@cmsbuild
Copy link
Contributor Author

@mtosi
Copy link
Contributor

mtosi commented Mar 20, 2017

PR #17996 opened
I would suggest to close this one
(I cannot do it, because I did not open it)

@silviodonato
Copy link
Contributor

Could you close this PR? (#17996)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment