Introduced explicit control of filters in the NZS mode #18100
Conversation
…ople using NZS data
|
A new Pull Request was created by @igv4321 (Igor Volobouev) for master. It involves the following packages: RecoLocalCalo/Configuration @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
| algorithm = dict( | ||
| useM2 = cms.bool(False), | ||
| useM3 = cms.bool(False) | ||
| ), | ||
| setNegativeFlagsQIE8 = cms.bool(False), | ||
| setNegativeFlagsQIE11 = cms.bool(False), | ||
| setNoiseFlagsQIE8 = cms.bool(True), |
There was a problem hiding this comment.
Just to check (as I'm not sure I fully understood the logic in the HBHEPhase1Reconstructor): shouldn't this setNoiseFlagsQIE8 be set to "False", as the other bools here, if you want to retrieve the info from DB (and therefore not to look it up in the constructor) ?
There was a problem hiding this comment.
"setNoiseFlagsQIE8" switch turns on certain filters in the rechit processing. These filters, in turn, set certain rechit flags. It looks like for NZS mode only this particular filter can provide some useful information (at least this is what Olga told me), while the parameters of this filter have not been derived yet for QIE11.
The use of filters is unrelated to choosing reco algorithm parameters from db or from cfi. This is an orthogonal issue.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
+1 |
Per discussion with NZS data consumers (Olga Kodolova), most HBHE filters are turned off in the Phase 1 NZS mode, and reco parameters are taken from DB