Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced explicit control of filters in the NZS mode #18100

Merged
merged 1 commit into from Mar 31, 2017
Merged

Introduced explicit control of filters in the NZS mode #18100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion RecoLocalCalo/Configuration/python/hcalLocalRecoNZS_cff.py
View file
Open in desktop
Expand Up @@ -22,11 +22,18 @@
import RecoLocalCalo.HcalRecProducers.HBHEPhase1Reconstructor_cfi
_phase1_hbherecoMB = RecoLocalCalo.HcalRecProducers.HBHEPhase1Reconstructor_cfi.hbheprereco.clone(
dropZSmarkedPassed = cms.bool(False),
recoParamsFromDB = cms.bool(False),
algorithm = dict(
useM2 = cms.bool(False),
useM3 = cms.bool(False)
),
setNegativeFlagsQIE8 = cms.bool(False),
setNegativeFlagsQIE11 = cms.bool(False),
setNoiseFlagsQIE8 = cms.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check (as I'm not sure I fully understood the logic in the HBHEPhase1Reconstructor): shouldn't this setNoiseFlagsQIE8 be set to "False", as the other bools here, if you want to retrieve the info from DB (and therefore not to look it up in the constructor) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"setNoiseFlagsQIE8" switch turns on certain filters in the rechit processing. These filters, in turn, set certain rechit flags. It looks like for NZS mode only this particular filter can provide some useful information (at least this is what Olga told me), while the parameters of this filter have not been derived yet for QIE11.

The use of filters is unrelated to choosing reco algorithm parameters from db or from cfi. This is an orthogonal issue.

setNoiseFlagsQIE11 = cms.bool(False),
setPulseShapeFlagsQIE8 = cms.bool(False),
setPulseShapeFlagsQIE11 = cms.bool(False),
setLegacyFlagsQIE8 = cms.bool(False),
setLegacyFlagsQIE11 = cms.bool(False)
)
hfprerecoMB = RecoLocalCalo.HcalRecProducers.hfprereco_cfi.hfprereco.clone(
dropZSmarkedPassed = cms.bool(False)
Expand Down