Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to consumes interface and getByToken for TrackerSeedGenerator #1811

Closed
wants to merge 4 commits into from

Conversation

thspeer
Copy link
Contributor

@thspeer thspeer commented Dec 13, 2013

No description provided.

thspeer and others added 3 commits December 11, 2013 12:47
Leave edm::ConsumesCollector to TrackerSeedGenerator hierarchy, since
e.g. TSGFromPropagation reads from event.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thspeer for CMSSW_7_0_X.

Changes to consumes interface and getByToken for TrackerSeedGenerator

It involves the following packages:

RecoTracker/ConversionSeedGenerators
RecoMuon/TrackerSeedGenerator
RecoTracker/SpecialSeedGenerators
RecoEgamma/EgammaHLTProducers
RecoTracker/TkSeedGenerator
RecoPixelVertexing/PixelTrackFitting
FastSimulation/Muons

@perrotta, @cmsbuild, @thspeer, @lveldere, @fwyzard, @Martin-Grunewald, @anton-a, @nclopezo, @giamman, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Martin-Grunewald
Copy link
Contributor

-1

Crash in HLT test:

%MSG-e FatalSystemSignal: EgammaHLTRegionalPixelSeedGeneratorProducers:hltL1SeededEgammaRegionalPixelSeedGenerator 13-Dec-2013 20:18:28 CET Run: 1 Event: 103
A fatal system signal has occurred: segmentation violation
%MSG

A fatal system signal has occurred: segmentation violation
The following is the call stack containing the origin of the signal.
NOTE:The first few functions on the stack are artifacts of processing the signa
l and can be ignored

#0 0x0000003a3aa9a075 in waitpid () from /lib64/libc.so.6
#1 0x0000003a3aa3c741 in do_system () from /lib64/libc.so.6
#2 0x00002b8760656ddf in TUnixSystem::StackTrace() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-13-1400/external/slc5_amd64_gcc481/lib/libCore.so
#3 0x00002b8763d28355 in sig_dostack_then_abort () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-13-1400/lib/slc5_amd64_gcc481/libFWCoreServices.so
#4
#5 0x00002b876fa7af9c in SeedGeneratorFromRegionHits::run(std::vector<TrajectorySeed, std::allocator >&, TrackingRegion const&, edm::Event co
nst&, edm::EventSetup const&) () from /scratch/CMS3/CMSSW_7_0_X_2013-12-13-1400/lib/slc5_amd64_gcc481/libRecoTrackerTkSeedGenerator.so
#6 0x00002b877bf6c3cd in EgammaHLTRegionalPixelSeedGeneratorProducers::produce (edm::Event&, edm::EventSetup const&) () from /scratch/CMS3/CMSSW_7_0_X_2013-12-13-1400/lib/slc5_amd64_gcc481/pluginRecoEgammaEgammaHLTProducers.so

@thspeer
Copy link
Contributor Author

thspeer commented Dec 16, 2013

Thanks. Which workflow did you run ?

@Martin-Grunewald
Copy link
Contributor

For example: runTheMatrix.py -l 25.0 -i 25.0

@thspeer
Copy link
Contributor Author

thspeer commented Dec 16, 2013

ok, got it, thanks.

@cmsbuild
Copy link
Contributor

Pull request #1811 was updated. @nclopezo, @lveldere, @cmsbuild, @anton-a, @thspeer, @giamman, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@thspeer
Copy link
Contributor Author

thspeer commented Dec 16, 2013

+1
Tested 02df29e in CMSSW_7_0_X_2013-12-16-0200_1824
No difference in reco as expected, based on RelMon and reco script

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

This pull request is not mergeable. @thspeer could you please rebase it?

Please have a look at:

http://cms-sw.github.io/cmssw/tutorial-forward-port.html

if you do not know how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants