Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hcal Plan1 validation plots #18159

Merged
merged 15 commits into from Apr 25, 2017
Merged

Hcal Plan1 validation plots #18159

merged 15 commits into from Apr 25, 2017

Commits on Apr 24, 2017

  1. Adds a "hep17" parameter to DQMOffline/Hcal/HcalRecHitsAnalyzer, Vali… 

    …dation/HcalDigis/HcalDigisValidation, Validation/HcalHits/HcalSimHitStudy.cc

This parameter turns on validation plots specific to 2017 Plan1 configuration

Specifying run2_2017 era will enable these plots
    @kencall @hatakeyamak
    kencall authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    075ae42 View commit details
    Browse the repository at this point in the history

  2. Adds HEP17 specific validation plots to Validation/HcalDigis 

    The presence of these plots is controlled by a parameter passed to the module and customized with eras
    @kencall @hatakeyamak
    kencall authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    386fc96 View commit details
    Browse the repository at this point in the history

  3. turn on rechit vs simhit comparisons

    @hatakeyamak
    hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    b4e93f3 View commit details
    Browse the repository at this point in the history

  4. Use dynaic eta range in HcalSimHitStudy

    @kencall @hatakeyamak
    kencall authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    a31a3fa View commit details
    Browse the repository at this point in the history

  5. Adjusted ranges to center bins for some hard-coded ieta plots

    @bcmcms @hatakeyamak
    bcmcms authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    a1c44c2 View commit details
    Browse the repository at this point in the history

  6. Hcal rechit emap validation plots use dynamically determined ieta and… 

    … iphi ranges.
    @kencall @hatakeyamak
    kencall authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    953296a View commit details
    Browse the repository at this point in the history

  7. Add additional validation plots to HcalRecHitsAnalyzer. These are to … 

    …support Plan1 configuration
    @kencall @hatakeyamak
    kencall authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    485ebc9 View commit details
    Browse the repository at this point in the history

  8. adjust range for QIE11 channels

    @hatakeyamak
    hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    c2f7759 View commit details
    Browse the repository at this point in the history

  9. HEP17 specific plots for simhits

    @hatakeyamak
    hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    104d74a View commit details
    Browse the repository at this point in the history

  10. number of depths setting now dynamic in simhit code

    @hatakeyamak
    hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    fde7f02 View commit details
    Browse the repository at this point in the history

  11. make the simhitcollection label configurable. adjust config for fasts… 

    …im and 2023
    @hatakeyamak
    hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    275c3b9 View commit details
    Browse the repository at this point in the history

  12. hep17 is changed from a string to boolean

    @kencall @hatakeyamak
    kencall authored and hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    b92d73d View commit details
    Browse the repository at this point in the history

  13. no longer necessary to skip Validation/HcalRecHits validation for pha… 

    …se2 after Sunada fix PR18237
    @hatakeyamak
    hatakeyamak committed Apr 24, 2017
    Copy the full SHA
    bd83832 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2017

  1. Simplified the simhit depth plots. Also, removed the hard-coded bin d… 

    …efinition from the Calotower DQMOffline code (used for Validation). Also, added a few iphi plots which are very useful for HEP17 validation.
    @hatakeyamak
    hatakeyamak committed Apr 25, 2017
    Copy the full SHA
    fe8c657 View commit details
    Browse the repository at this point in the history

  2. clean up unnecessary MonitorElement

    @hatakeyamak
    hatakeyamak committed Apr 25, 2017
    Copy the full SHA
    f96ebf8 View commit details
    Browse the repository at this point in the history