Adding distributions over eta and phi #18413

natalia-korneeva · 2017-04-19T20:03:49Z

Following last discussions with btagging@HLT conveners the eta/phi dimension's are to be monitored for future campaigns.

cmsbuild · 2017-04-19T20:04:07Z

A new Pull Request was created by @natalia-korneeva (Natalia Korneeva) for master.

It involves the following packages:

HLTriggerOffline/Btag

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

natalia-korneeva · 2017-04-19T22:22:12Z

New distributions for the 9_0_0_2016 release are available here
https://twiki.cern.ch/twiki/bin/view/Sandbox/NataliaTsirovaSandbox#New_distributions_over_eta_and_p
They are Efficiency vs eta and Efficiency vs phi for b, c, light quarks.

dmitrijus · 2017-04-20T08:04:05Z

+1

cmsbuild · 2017-04-20T08:04:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19281/console Started: 2017/04/20 10:05

cmsbuild · 2017-04-20T08:04:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

cmsbuild · 2017-04-20T09:53:08Z

+1
Tested at: 7a51fbf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18413/19281/summary.html

cmsbuild · 2017-04-20T09:53:11Z

Comparison job queued.

cmsbuild · 2017-04-20T12:03:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18413/19281/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3274 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1826205
DQMHistoTests: Total failures: 30110
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1795922
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-04-21T12:31:11Z

HLTriggerOffline/Btag/src/HLTBTagHarvestingAnalyzer.cc

@@ -46,13 +46,29 @@ HLTBTagHarvestingAnalyzer::dqmEndJob(DQMStore::IBooker & ibooker, DQMStore::IGet
 				efficsOK[flavour]=isOK;
 			}
 			label= m_histoName.at(ind)+std::string("___");
+			TString labelEta = label;


Hi @natalia-korneeva - as not to make the existing issues with string conversions in this class worse, please change the types of labelEta and labelPhi to be std::string. That will avoid several conversions between string<->Tstring in the code you've added below.

davidlange6 · 2017-04-21T12:32:38Z

HLTriggerOffline/Btag/src/HLTBTagPerformanceAnalyzer.cc

@@ -189,11 +197,19 @@ void HLTBTagPerformanceAnalyzer::bookHistograms(DQMStore::IBooker & ibooker, edm
 		int nBinsPt=60;
 		double pTmin=30;
 		double pTMax=330;
+		int nBinsPhi=54;
+		double phimin=-3.14;


could you use M_PI here?

davidlange6 · 2017-04-23T14:37:18Z

-1
pending answers to small comments

cmsbuild · 2017-04-26T12:51:22Z

Pull request #18413 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

natalia-korneeva · 2017-04-26T12:52:26Z

PR updated according to requests.

mtosi · 2017-04-26T12:59:39Z

as said, and agreed at the TSG meeting today
please,

add such feature in the code used by the DQM step
add plots for the HEP17, HEM17 and HEP18 slices
add ratio plots between HEP17, HEM17 and HEP18 (probably by using the GenericDQMClient)

natalia-korneeva · 2017-04-27T14:33:37Z

@mtosi, as discussed today at BTV@HLT meeting we propose to leave this PR as it is to be able to monitor the full eta and phi distributions.
The HEP17 etc. plots are to be added with the separate PR as a separate task, this part is in preparation now.

mtosi · 2017-04-27T14:42:11Z

thanks for the clarification, hoping it will come soon ;)

heppye · 2017-04-27T14:51:22Z

@mtosi , thanks for the quick comment and hope this separate PRs plan is fine with release managements. @dmitrijus @davidlange6 , could u please have a look and sign off again? Thanks.

dmitrijus · 2017-05-02T13:38:13Z

+1

cmsbuild · 2017-05-02T13:38:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19517/console Started: 2017/05/02 15:56

cmsbuild · 2017-05-02T13:38:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-05-02T15:19:05Z

+1
Tested at: 5d04562
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18413/19517/summary.html

cmsbuild · 2017-05-02T15:19:08Z

Comparison job queued.

cmsbuild · 2017-05-02T18:35:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18413/19517/summary.html

Comparison Summary:

You potentially added 110 lines to the logs
Reco comparison results: 3319 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1831629
DQMHistoTests: Total failures: 62075
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1769374
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

davidlange6 · 2017-05-04T06:49:36Z

+1

Adding distributions over eta and phi

7a51fbf

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 19, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Apr 19, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Apr 20, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 20, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 20, 2017

davidlange6 reviewed Apr 21, 2017

View reviewed changes

cmsbuild added orp-rejected and removed orp-pending labels Apr 23, 2017

cmsbuild added dqm-pending pending-signatures tests-pending labels Apr 26, 2017

swertz mentioned this pull request Apr 28, 2017

B-tag DQM/Val.: Add efficiency plots vs. eta and phi for cut on discriminators #18518

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 2, 2017

cmsbuild added tests-started and removed tests-pending labels May 2, 2017

cmsbuild added tests-approved and removed tests-started labels May 2, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 2, 2017

cmsbuild added orp-approved and removed orp-pending labels May 4, 2017

cmsbuild merged commit 1e992ec into cms-sw:master May 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding distributions over eta and phi #18413

Adding distributions over eta and phi #18413

natalia-korneeva commented Apr 19, 2017

cmsbuild commented Apr 19, 2017 •

edited by smuzaffar

natalia-korneeva commented Apr 19, 2017

dmitrijus commented Apr 20, 2017

cmsbuild commented Apr 20, 2017 •

edited

cmsbuild commented Apr 20, 2017

cmsbuild commented Apr 20, 2017

cmsbuild commented Apr 20, 2017

cmsbuild commented Apr 20, 2017

davidlange6 Apr 21, 2017

davidlange6 Apr 21, 2017

davidlange6 commented Apr 23, 2017

cmsbuild commented Apr 26, 2017

natalia-korneeva commented Apr 26, 2017

mtosi commented Apr 26, 2017

natalia-korneeva commented Apr 27, 2017

mtosi commented Apr 27, 2017

heppye commented Apr 27, 2017

dmitrijus commented May 2, 2017

cmsbuild commented May 2, 2017 •

edited

cmsbuild commented May 2, 2017

cmsbuild commented May 2, 2017

cmsbuild commented May 2, 2017

cmsbuild commented May 2, 2017

davidlange6 commented May 4, 2017

Adding distributions over eta and phi #18413

Adding distributions over eta and phi #18413

Conversation

natalia-korneeva commented Apr 19, 2017

cmsbuild commented Apr 19, 2017 • edited by smuzaffar

natalia-korneeva commented Apr 19, 2017

dmitrijus commented Apr 20, 2017

cmsbuild commented Apr 20, 2017 • edited

cmsbuild commented Apr 20, 2017

cmsbuild commented Apr 20, 2017

cmsbuild commented Apr 20, 2017

cmsbuild commented Apr 20, 2017

davidlange6 Apr 21, 2017

Choose a reason for hiding this comment

davidlange6 Apr 21, 2017

Choose a reason for hiding this comment

davidlange6 commented Apr 23, 2017

cmsbuild commented Apr 26, 2017

natalia-korneeva commented Apr 26, 2017

mtosi commented Apr 26, 2017

natalia-korneeva commented Apr 27, 2017

mtosi commented Apr 27, 2017

heppye commented Apr 27, 2017

dmitrijus commented May 2, 2017

cmsbuild commented May 2, 2017 • edited

cmsbuild commented May 2, 2017

cmsbuild commented May 2, 2017

cmsbuild commented May 2, 2017

cmsbuild commented May 2, 2017

davidlange6 commented May 4, 2017

cmsbuild commented Apr 19, 2017 •

edited by smuzaffar

cmsbuild commented Apr 20, 2017 •

edited

cmsbuild commented May 2, 2017 •

edited