Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uGMT online DQM muon copy validation #18500

Merged
merged 2 commits into from May 4, 2017

Conversation

thomreis
Copy link
Contributor

Online DQM histograms to validate the uGMT muon copies 1-5 against uGMT muons.
The additional copies are sent to uGT boards 1-5 and will be read out for validation events.
This checks that the collections contain the same muons.

Additionally, a histogram title is corrected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @kreczko, @batinkov this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19460/console Started: 2017/04/28 15:24

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18500/19460/summary.html

Comparison Summary:

  • You potentially added 54 lines to the logs
  • Reco comparison results: 3362 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778687
  • DQMHistoTests: Total failures: 32423
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1746091
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@@ -117,3 +117,41 @@
verbose = cms.untracked.bool(False),
)

# The five modules below compare the primary unpacked uGMT muon collection to goes to uGT board 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @thomreis @rekovic - this file needs to be renamed as a "cff" not a "cfi" (which should define one module). Please have a look in a near-term followup pr. thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 so I should make one cfi file for every module and then group them in a cff?

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aae5a1f into cms-sw:master May 4, 2017
@thomreis thomreis deleted the uGMT-DQM_muon-copy-validation_91x branch May 4, 2017 13:24
This was referenced May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants