Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uGMT online DQM muon copy validation #18500

Merged
merged 2 commits into from May 4, 2017
Merged

uGMT online DQM muon copy validation #18500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa0b51
Add checks for additional uGMT muon copies
thomreis Apr 27, 2017
ab54e64
Change ZS histogram name and title.
thomreis Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py
View file
Open in desktop
Expand Up @@ -67,7 +67,12 @@
process.l1tStage2OnlineDQM +
process.hltFatEventFilter +
# process.selfFatEventFilter +
process.l1tStage2uGMTZeroSuppFatEvts
process.l1tStage2uGMTZeroSuppFatEvts +
process.l1tStage2uGMTMuonVsuGMTMuonCopy1 +
process.l1tStage2uGMTMuonVsuGMTMuonCopy2 +
process.l1tStage2uGMTMuonVsuGMTMuonCopy3 +
process.l1tStage2uGMTMuonVsuGMTMuonCopy4 +
process.l1tStage2uGMTMuonVsuGMTMuonCopy5
)

# Remove DQM Modules
Expand Down
38 changes: 38 additions & 0 deletions DQM/L1TMonitor/python/L1TStage2uGMT_cfi.py
View file
Open in desktop
Expand Up @@ -117,3 +117,41 @@
verbose = cms.untracked.bool(False),
)

# The five modules below compare the primary unpacked uGMT muon collection to goes to uGT board 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @thomreis @rekovic - this file needs to be renamed as a "cff" not a "cfi" (which should define one module). Please have a look in a near-term followup pr. thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 so I should make one cfi file for every module and then group them in a cff?

# to the unpacked uGMT muon collections that are sent to uGT boards 1 to 5.
# Only muons that do not match are filled in the histograms
l1tStage2uGMTMuonVsuGMTMuonCopy1 = cms.EDAnalyzer(
"L1TStage2MuonComp",
muonCollection1 = cms.InputTag("gmtStage2Digis", "Muon"),
muonCollection2 = cms.InputTag("gmtStage2Digis", "MuonCopy1"),
monitorDir = cms.untracked.string("L1T/L1TStage2uGMT/uGMTMuonCopies/uGMTMuonCopy1"),
muonCollection1Title = cms.untracked.string("uGMT muons"),
muonCollection2Title = cms.untracked.string("uGMT muons copy 1"),
summaryTitle = cms.untracked.string("Summary of comparison between uGMT muons and uGMT muon copy 1"),
verbose = cms.untracked.bool(False),
)

l1tStage2uGMTMuonVsuGMTMuonCopy2 = l1tStage2uGMTMuonVsuGMTMuonCopy1.clone()
l1tStage2uGMTMuonVsuGMTMuonCopy2.muonCollection2 = cms.InputTag("gmtStage2Digis", "MuonCopy2")
l1tStage2uGMTMuonVsuGMTMuonCopy2.monitorDir = cms.untracked.string("L1T/L1TStage2uGMT/uGMTMuonCopies/uGMTMuonCopy2")
l1tStage2uGMTMuonVsuGMTMuonCopy2.muonCollection2Title = cms.untracked.string("uGMT muons copy 2")
l1tStage2uGMTMuonVsuGMTMuonCopy2.summaryTitle = cms.untracked.string("Summary of comparison between uGMT muons and uGMT muon copy 2")

l1tStage2uGMTMuonVsuGMTMuonCopy3 = l1tStage2uGMTMuonVsuGMTMuonCopy1.clone()
l1tStage2uGMTMuonVsuGMTMuonCopy3.muonCollection2 = cms.InputTag("gmtStage2Digis", "MuonCopy3")
l1tStage2uGMTMuonVsuGMTMuonCopy3.monitorDir = cms.untracked.string("L1T/L1TStage2uGMT/uGMTMuonCopies/uGMTMuonCopy3")
l1tStage2uGMTMuonVsuGMTMuonCopy3.muonCollection2Title = cms.untracked.string("uGMT muons copy 3")
l1tStage2uGMTMuonVsuGMTMuonCopy3.summaryTitle = cms.untracked.string("Summary of comparison between uGMT muons and uGMT muon copy 3")

l1tStage2uGMTMuonVsuGMTMuonCopy4 = l1tStage2uGMTMuonVsuGMTMuonCopy1.clone()
l1tStage2uGMTMuonVsuGMTMuonCopy4.muonCollection2 = cms.InputTag("gmtStage2Digis", "MuonCopy4")
l1tStage2uGMTMuonVsuGMTMuonCopy4.monitorDir = cms.untracked.string("L1T/L1TStage2uGMT/uGMTMuonCopies/uGMTMuonCopy4")
l1tStage2uGMTMuonVsuGMTMuonCopy4.muonCollection2Title = cms.untracked.string("uGMT muons copy 4")
l1tStage2uGMTMuonVsuGMTMuonCopy4.summaryTitle = cms.untracked.string("Summary of comparison between uGMT muons and uGMT muon copy 4")

l1tStage2uGMTMuonVsuGMTMuonCopy5 = l1tStage2uGMTMuonVsuGMTMuonCopy1.clone()
l1tStage2uGMTMuonVsuGMTMuonCopy5.muonCollection2 = cms.InputTag("gmtStage2Digis", "MuonCopy5")
l1tStage2uGMTMuonVsuGMTMuonCopy5.monitorDir = cms.untracked.string("L1T/L1TStage2uGMT/uGMTMuonCopies/uGMTMuonCopy5")
l1tStage2uGMTMuonVsuGMTMuonCopy5.muonCollection2Title = cms.untracked.string("uGMT muons copy 5")
l1tStage2uGMTMuonVsuGMTMuonCopy5.summaryTitle = cms.untracked.string("Summary of comparison between uGMT muons and uGMT muon copy 5")

2 changes: 1 addition & 1 deletion DQM/L1TMonitor/src/L1TMP7ZeroSupp.cc
View file
Open in desktop
Expand Up @@ -92,7 +92,7 @@ void L1TMP7ZeroSupp::bookCapIdHistograms(DQMStore::IBooker& ibooker, const unsig
zeroSuppValMap_[id]->setBinLabel(ZSBLKSBADFALSEPOS+1, "false pos.", 1);
zeroSuppValMap_[id]->setBinLabel(ZSBLKSBADFALSENEG+1, "false neg.", 1);

readoutSizeNoZSMap_[id] = ibooker.book1D("readoutSizeNoZS", (sizeTitleText + "size without zero suppression").c_str(), 100, 0, maxFedReadoutSize_);
readoutSizeNoZSMap_[id] = ibooker.book1D("readoutSize", (sizeTitleText + "size").c_str(), 100, 0, maxFedReadoutSize_);
readoutSizeNoZSMap_[id]->setAxisTitle("size (byte)", 1);
readoutSizeZSMap_[id] = ibooker.book1D("readoutSizeZS", (sizeTitleText + "size with zero suppression").c_str(), 100, 0, maxFedReadoutSize_);
readoutSizeZSMap_[id]->setAxisTitle("size (byte)", 1);
Expand Down