Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92X] Fix configuration for DA_vect clusterizer in PV Validation tool (after #18330 merging) #18561

Merged
merged 1 commit into from May 5, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 4, 2017

Title says it all. Solves issue reported at #18330

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2017

Some support plots, validating the change (test run 275657, HLTPhysics 2016C Dataset):
At final plot level regressions are negligible in the biases:

biasescanvas_testforpr18561this_pr_vs_910pre2

there is an (unexpected?) improvement in the pulls epecially in the z-projection:

pullscanvas_testforpr18561this_pr_vs_910pre2

that is confirmed in the non-differential pull distribution:

c1_ratio_pulltrkz_all_da

vertex chisquare probabilty gets much flatter

c1_ratio_h_fitvtxchi2prob_refitvertexfeatures

and track weights much more peaked at 1.
c1_ratio_h_fitvtxtrackaverageweight__refitvertexfeatures

@arunhep
Copy link
Contributor

arunhep commented May 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19568/console Started: 2017/05/04 14:08

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18561/19568/summary.html

Comparison Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 3322 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1835853
  • DQMHistoTests: Total failures: 46777
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1788896
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@mmusich mmusich changed the title Fix configuration for DA_vect clusterizer in PV Validation tool (after #18330 merging) [92X] Fix configuration for DA_vect clusterizer in PV Validation tool (after #18330 merging) May 4, 2017
@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2017

type bugfix

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2017

@arunhep. This PR is not expected to change anything run in relval tests and should fix the issue in the unit tests in recent IBs such as: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_1_X_2017-05-03-1100/unitTestLogs/Alignment/OfflineValidation

@arunhep
Copy link
Contributor

arunhep commented May 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0b1e240 into cms-sw:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants