New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[92X] Fix configuration for DA_vect clusterizer in PV Validation tool (after #18330 merging) #18561
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Some support plots, validating the change (test run 275657, there is an (unexpected?) improvement in the pulls epecially in the that is confirmed in the non-differential pull distribution: vertex chisquare probabilty gets much flatter |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
type bugfix |
@arunhep. This PR is not expected to change anything run in relval tests and should fix the issue in the unit tests in recent IBs such as: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_1_X_2017-05-03-1100/unitTestLogs/Alignment/OfflineValidation |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Title says it all. Solves issue reported at #18330