Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined tools for muon system aging/masking for upgrade studies (91X) #18571

Merged
merged 22 commits into from May 8, 2017
Merged

Combined tools for muon system aging/masking for upgrade studies (91X) #18571

merged 22 commits into from May 8, 2017

Conversation

battibass
Copy link

This is a backport of #18199 to 91X

sunilUIET and others added 22 commits March 17, 2017 13:59
@sunilUIET
cleaned setup
12f6eb9
@aminnj
Merged muonSysAging91X_v2 from repository sunilUIET
92742ba
@aminnj
add CSC filtering
e5940bd
@sunilUIET
Merge pull request cms-sw#2 from aminnj/csc-aging-integration_90X_v1
36b7f40 
CSC aging integration for 90X
@sunilUIET
Merged muonSysAging91X_v2 from repository sunilUIET
13becad
@sunilUIET
fixes for GEM masking and ME0 masking included
677e912
@sunilUIET
Merged muonSysAging91X_v2 from repository sunilUIET
be3966a
@sunilUIET
fix for ME0
655ef2d
Merged muonSysAging91X_v2 from repository sunilUIET
d1fa703
Removed MuonSysAging duplicate
64ce9f6
Cleanup before any integration
0cbe770
Merging of DT, RPC, CSC, GEM, ME0 aging and masking tools
2654ace
move to edm::stream::EDProducer, reduce code duplication, cleanup
f5fd92a
Fix era customization
78dd79e
fix includes
f45083f
remove function used for testing
876962a
new organization of cond format and producer code in different packages
7b5951b
buildfile cleanup, cff print to stderr, update variable names, use mo…
8baf0a2 
…re recent c++ in digi loops
Moving EDProducers for aging to SimMuon/XY(Z)Digis, using fillDescrip…
3f8de8c 
…tors to generate cfi
GEM EDProducer bugfix
1681c6f
Fix dictionary warning
2ad4c71
Use const references in digi loops, update customization function
ad5024a
@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone May 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @battibass (Carlo Battilana) for CMSSW_9_1_X.

It involves the following packages:

CondCore/RecoMuonPlugins
CondFormats/DataRecord
CondFormats/RecoMuonObjects
SimMuon/CSCDigitizer
SimMuon/Configuration
SimMuon/DTDigitizer
SimMuon/GEMDigitizer
SimMuon/RPCDigitizer

@ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @ggovi, @mmusich, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @tocheng, @ptcox, @trocino this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented May 4, 2017

Backport of #18199

@kpedro88
Copy link
Contributor

kpedro88 commented May 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19573/console Started: 2017/05/04 17:12

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

+1
Tested at: ad5024a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18571/19573/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18571/19573/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1652 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1835819
  • DQMHistoTests: Total failures: 40528
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1795111
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented May 7, 2017

+1

@civanch
Copy link
Contributor

civanch commented May 8, 2017

+1

@davidlange6 davidlange6 merged commit 9c49318 into cms-sw:CMSSW_9_1_X May 8, 2017
@battibass battibass deleted the muonSysAgingComb91X branch April 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending backport comparison-available db-pending orp-pending pending-signatures simulation-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@battibass @cmsbuild @kpedro88 @civanch @davidlange6 @sunilUIET @aminnj